[go: nahoru, domu]

Page MenuHomePhabricator

Convert Special:CentralAuth to use OOUI
Open, Needs TriagePublic

Description

Without action

BeforeAfter
before.JPG (638×1 px, 66 KB)
after.JPG (638×1 px, 69 KB)

With action

BeforeAfter
before1.JPG (634×1 px, 65 KB)
after1.JPG (637×1 px, 70 KB)

Event Timeline

Paladox raised the priority of this task from to Needs Triage.
Paladox updated the task description. (Show Details)
Paladox added a project: UI-Standardization.
Paladox subscribed.

Change 424373 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/CentralAuth@master] Partially Convert Special:CentralAuth to use OOUI

https://gerrit.wikimedia.org/r/424373

Change 424373 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Partially convert Special:CentralAuth to use OOUI

https://gerrit.wikimedia.org/r/424373

Change 479584 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/CentralAuth@master] Use DerivativeContext in Special:CentralAuth

https://gerrit.wikimedia.org/r/479584

@matmarex Change 479584 needs to deploy as soon as possible.

Since I had to figure out why: the issue is that viewing https://meta.wikimedia.org/wiki/Special:CentralAuth/foo, then typing in a different username and submitting the form, result in a URL like "https://meta.wikimedia.org/wiki/Special:CentralAuth/foo?target=bar" rather than "https://meta.wikimedia.org/wiki/Special:CentralAuth?target=bar" (the URL still includes the previous usename).

However, the page still works correctly. Only the URL looks silly. So while this is a bug, I don't think it is severe enough for me to be deploying it. Feel free to schedule a SWAT deployment yourself though; the next slot is on Monday (https://wikitech.wikimedia.org/wiki/Deployments).

Change 479584 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Use DerivativeContext in Special:CentralAuth

https://gerrit.wikimedia.org/r/479584

@Volker_E Will we need to convert the legend of these both?

Global account information.png (654×1 px, 183 KB)

I have done my work on Global account information. Check it out.

Screenshot_2018-12-17 Global account manager for AA - AlphaWiki.png (210×1 px, 15 KB)

@Jayprakash12345 I have too little information and insight (and time right now) to give you useful feedback. I do think though, that we should go away from normal fieldset treatment and transform such pieces to OOUI when possible. Do you have more specific questions?

What the page looks like on mobile currently:

image.png (925×1 px, 104 KB)