[go: nahoru, domu]
Page MenuHomePhabricator
Create Task
Maniphest T132523

Only first instance of title should be bolded in hovercard text
Closed, ResolvedPublic
Actions

Assigned To
• Prtksxna
Authored By
• JKatzWMF
Apr 12 2016, 10:26 PM
Tags
Referenced Files
F3866900: Screenshot 2016-04-10 17.04.21.png
Apr 12 2016, 10:27 PM
F3866894: Screenshot 2016-04-10 17.06.25.png
Apr 12 2016, 10:26 PM
F3866892: Screenshot 2016-04-10 17.06.42.png
Apr 12 2016, 10:26 PM
Subscribers
Aklapper
gerritbot
• JKatzWMF
• Nirzar
• Prtksxna
TerraCodes

Description

Currently, the title of an article is bolded in the preview text. This only needs to happen one time. The second time is visually jarring to the user and unecessary.

"As a user, I am bothered by seeing the same phrase repeatedly bolded in hovercards"

Screenshot 2016-04-10 17.06.42.png (286×520 px, 125 KB)

Screenshot 2016-04-10 17.06.25.png (221×336 px, 46 KB)

Screenshot 2016-04-10 17.04.21.png (391×302 px, 180 KB)

Details

SubjectRepoBranchLines +/-
Bold only first instance of title in extractmediawiki/extensions/Popupsmaster+9 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

• JKatzWMF created this task.Apr 12 2016, 10:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 12 2016, 10:26 PM
• JKatzWMF updated the task description. (Show Details)Apr 12 2016, 10:27 PM
• Prtksxna subscribed.Apr 13 2016, 1:21 AM

The issue doesn't mention it, but if I remember correctly, this was part of the original design T67098: Hovercards: Make snippet text in hovercard which matches the article title bold. Not that we shouldn't change it now, just pointing it out.

• JKatzWMF added a subscriber: • Nirzar.Apr 13 2016, 3:33 PM

@Prtksxna Thanks for pointing that out. I find it visually and conceptually unhelpful, but interested in learning if you or @Nirzar feel/think it adds value.

• Prtksxna added a comment.Apr 13 2016, 3:34 PM

I personally feel that a single highlight is enough.

gerritbot subscribed.Apr 13 2016, 3:56 PM

Change 283212 had a related patch set uploaded (by Prtksxna):
Bold only first instance of title in extract

https://gerrit.wikimedia.org/r/283212

gerritbot added a project: Patch-For-Review.Apr 13 2016, 3:56 PM
Jdlrobson assigned this task to • Nirzar.Apr 13 2016, 5:14 PM
Jdlrobson triaged this task as Low priority.
• Nirzar added a comment.Apr 13 2016, 6:40 PM

I personally feel that a single highlight is enough.

I agree

• JKatzWMF added a parent task: T70860: [GOAL] Graduate Page Previews feature (Popups extension) out of Beta Feature.Apr 13 2016, 10:03 PM

@Nirzar @Prtksxna awesome! quick movement.

Jdlrobson reassigned this task from • Nirzar to • Prtksxna.Apr 18 2016, 10:06 AM
gerritbot added a comment.Apr 18 2016, 10:14 AM

Change 283212 merged by jenkins-bot:
Bold only first instance of title in extract

https://gerrit.wikimedia.org/r/283212

Jdlrobson closed this task as Resolved.Apr 18 2016, 2:53 PM
Jdlrobson added projects: Unplanned-Sprint-Work, Reading-Web-Sprint-70-Lady-and-the-Trumps.
Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.
phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.Apr 19 2016, 5:30 AM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)).Apr 20 2016, 12:02 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 20 2016, 12:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits