CX2: Blocklevel translation units inside a section is not translatable
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	santhosh
	Apr 28 2017, 12:17 PM

Description

The section translation unit we defined has the following problem. It behaves like a placeholder in translation column, onlick get translated. If there are block level translation units inside the section, for example, Tables, the whole table get disappeared from source column

Details

	Subject	Repo	Branch	Lines +/-
	CX2: Do not wrap block subtranslation units with <section> tag	mediawiki/extensions/ContentTranslation	master	+2 -3

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	santhosh	T152586 Reorganize the CX classes using OOjs/OOUI (tracker)
Resolved	santhosh	T164067 CX2: Blocklevel translation units inside a section is not translatable
		· · ·

Event Timeline

santhosh created this task.Apr 28 2017, 12:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2017, 12:17 PM

Amire80 edited projects, added Language-team April-June 2017 (Language-2017 Sprint 7); removed Language-team April-June 2017 (Language-2017 Sprint 6).May 2 2017, 7:08 AM

santhosh updated the task description. (Show Details)May 2 2017, 11:08 AM

Figured out that this is because unconditional wrapping of block level elements with <section> tag in mw.cx.ui.SectionTranslationUnit.prototype.createSourceSection

Change 351291 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] CX2: Do not wrap block subtranslation units with <section> tag

https://gerrit.wikimedia.org/r/351291

gerritbot added a project: Patch-For-Review.May 2 2017, 11:17 AM

santhosh moved this task from Backlog to In Review on the Language-team April-June 2017 (Language-2017 Sprint 7) board.May 2 2017, 11:23 AM

Change 351291 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CX2: Do not wrap block subtranslation units with <section> tag

https://gerrit.wikimedia.org/r/351291

Nikerabbit removed a project: Patch-For-Review.May 2 2017, 1:42 PM

Nikerabbit moved this task from In Review to QA on the Language-team April-June 2017 (Language-2017 Sprint 7) board.

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 2 2017, 2:00 PM

Amire80 moved this task from QA to Done on the Language-team April-June 2017 (Language-2017 Sprint 7) board.May 3 2017, 6:34 AM

santhosh closed this task as Resolved.May 16 2017, 6:41 AM