RC page - default selection of '50 changes in 7 days' is sticky
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Etonkovidova
	Jul 22 2017, 1:38 AM

Description

In betalabs go to RC page with the default filters; the default is set for the number of change 50 changes in last 7 days
Try to select a different number of days - it is not possible: clicking on 14 or 30 will not produce any changes and won't make the selection of 14 or 30 displayed selected.

Screen Shot 2017-07-21 at 6.37.11 PM.png (385×803 px, 80 KB)

The screen recording shows that clicking on the different days has no effect.

days_cannot_be selected.mov2 MBDownload

Details

Subject	Repo	Branch	Lines +/-
RCFilters: Create a sticky preference for days/limit groups	mediawiki/core	master	+277 -96
RCFilters: Read base value of limit/days from preference	mediawiki/core	wmf/1.30.0-wmf.11	+85 -55
RCFilters: Read base value of limit/days from preference	mediawiki/core	master	+85 -55

Customize query in gerrit

Related Objects

Mentioned In: T171081: Trash can button (reset to defaults) resets days and limit in model but not UI
Mentioned Here: T171081: Trash can button (reset to defaults) resets days and limit in model but not UI

Event Timeline

Etonkovidova created this task.Jul 22 2017, 1:38 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2017, 1:38 AM

Etonkovidova mentioned this in T171081: Trash can button (reset to defaults) resets days and limit in model but not UI.Jul 22 2017, 1:41 AM

Etonkovidova updated the task description. (Show Details)Jul 24 2017, 4:54 PM

This is working for me now; perhaps it was the same issue as T171081: Trash can button (reset to defaults) resets days and limit in model but not UI ?

Change 367715 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Read base value of limit/days from preference

https://gerrit.wikimedia.org/r/367715

Change 367716 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] [wip] RCFilters: Make days/limit a sticky preference

https://gerrit.wikimedia.org/r/367716

Checked the fix in betalabs.

Etonkovidova closed this task as Resolved.Jul 27 2017, 12:22 AM

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Change 367715 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Read base value of limit/days from preference

https://gerrit.wikimedia.org/r/367715

ReleaseTaggerBot added a project: MW-1.30-release-notes.Jul 27 2017, 9:01 PM

Change 368309 had a related patch set uploaded (by Catrope; owner: Mooeypoo):
[mediawiki/core@wmf/1.30.0-wmf.11] RCFilters: Read base value of limit/days from preference

https://gerrit.wikimedia.org/r/368309

Change 368309 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.11] RCFilters: Read base value of limit/days from preference

https://gerrit.wikimedia.org/r/368309

Mentioned in SAL (#wikimedia-operations) [2017-07-27T23:48:39Z] <catrope@tin> Synchronized php-1.30.0-wmf.11/resources/src/mediawiki.rcfilters/: T171368 (duration: 00m 42s)

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)); removed MW-1.30-release-notes.Jul 28 2017, 12:01 AM

Change 367716 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Create a sticky preference for days/limit groups