Echo popups should always open downwards
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Dec 19 2017, 9:09 PM

Description

Echo popups should probably. always open downwards

In T183069#3848367, @Nikerabbit wrote:

Does that fix also access echo popups becoming completely inaccessible on small screens?

Not that it works very well on screens this small, but it's still better I guess…

Details

	Subject	Repo	Branch	Lines +/-
	mw.echo.ui.NotificationBadgeWidget: Do not flip popups	mediawiki/extensions/Echo	master	+1 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	matmarex	T183296 Echo popups should always open downwards
Resolved	matmarex	T183069 Issues with OOUI menus/popups that open upwards being overlapped by things
Resolved	Volker_E	T183195 Release OOUI v0.24.4 with some backported patches

Event Timeline

matmarex created this task.Dec 19 2017, 9:09 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptDec 19 2017, 9:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

matmarex added a subtask: T183069: Issues with OOUI menus/popups that open upwards being overlapped by things.Dec 19 2017, 9:09 PM

Change 400781 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Echo@master] mw.echo.ui.NotificationBadgeWidget: Do not flip popups

https://gerrit.wikimedia.org/r/400781

gerritbot added a project: Patch-For-Review.Dec 29 2017, 11:52 PM

Change 400781 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] mw.echo.ui.NotificationBadgeWidget: Do not flip popups

https://gerrit.wikimedia.org/r/400781

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Jan 2 2018, 11:00 AM

matmarex closed this task as Resolved.Jan 3 2018, 8:38 PM

matmarex removed a project: Patch-For-Review.

matmarex closed subtask T183069: Issues with OOUI menus/popups that open upwards being overlapped by things as Resolved.Jan 3 2018, 8:46 PM