[go: nahoru, domu]
Page MenuHomePhabricator
Create Task
Maniphest T185158

Deprecate and remove 'alert' indicator
Closed, ResolvedPublic
Actions

Description

On searching through further icon/indicator usages, I've identified that 'alert' indicator seems to be only used in two places:

  • As code example in IndicatorWidget.js
  • In Flow's MentionInspector where it actually should be an icon and not an indicator

image.png (310×814 px, 23 KB)

(Current UI)

As we want to keep duplication of icons in our library low and also reduce the number of indicators to only the most important special cases, we should:

Details

SubjectRepoBranchLines +/-
[BREAKING CHANGE] indicators: Remove 'alert', deprecated in v0.25.2oojs/uimaster+0 -15
Replace deprecated 'alert' indicator with similar iconmediawiki/extensions/Flowmaster+4 -4
demos, docs: Replace 'alert' indicator, as it's deprecatedoojs/uimaster+30 -30
[DEPRECATING CHANGE] icons: Flag indicator 'alert' as to be removedoojs/uimaster+8 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E triaged this task as High priority.Jan 17 2018, 11:05 PM
Volker_E created this task.
gerritbot subscribed.Jan 17 2018, 11:31 PM

Change 404884 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [DEPRECATING CHANGE] icons: Flag indicator 'alert'as to be removed

https://gerrit.wikimedia.org/r/404884

gerritbot added a project: Patch-For-Review.Jan 17 2018, 11:31 PM
gerritbot added a comment.Jan 17 2018, 11:36 PM

Change 404885 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] Replace 'alert' indicator as it's deprecated

https://gerrit.wikimedia.org/r/404885

gerritbot added a comment.Jan 18 2018, 7:10 PM

Change 404884 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] icons: Flag indicator 'alert' as to be removed

https://gerrit.wikimedia.org/r/404884

Jdforrester-WMF removed a project: Patch-For-Review.Jan 18 2018, 7:31 PM
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Jan 18 2018, 7:36 PM

Change 405045 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[oojs/ui@master] [BREAKING CHANGE] indicators: Remove 'alert', deprecated in v0.25.2

https://gerrit.wikimedia.org/r/405045

gerritbot added a project: Patch-For-Review.Jan 18 2018, 7:36 PM
gerritbot added a comment.Jan 18 2018, 7:46 PM

Change 404885 merged by jenkins-bot:
[oojs/ui@master] demos, docs: Replace 'alert' indicator, as it's deprecated

https://gerrit.wikimedia.org/r/404885

gerritbot added a comment.Jan 18 2018, 10:13 PM

Change 405204 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Flow@master] Replace deprecated 'alert' indicator with similar icon

https://gerrit.wikimedia.org/r/405204

Volker_E moved this task from Backlog to Reviewing on the OOUI board.Jan 18 2018, 11:56 PM
gerritbot added a comment.Jan 19 2018, 6:15 PM

Change 405204 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Replace deprecated 'alert' indicator with similar icon

https://gerrit.wikimedia.org/r/405204

Jdforrester-WMF removed a project: Patch-For-Review.Jan 19 2018, 6:15 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF moved this task from Reviewing to Waiting for breaking release on the OOUI board.
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 19 2018, 7:01 PM
Volker_E updated the task description. (Show Details)Jan 31 2018, 2:21 AM
Volker_E moved this task from Unsorted to OOUI on the UI-Standardization board.Mar 19 2018, 5:06 AM
Jdforrester-WMF moved this task from Waiting for breaking release to OOUI-0.26.0 on the OOUI board.Mar 20 2018, 6:01 PM
Jdforrester-WMF edited projects, added OOUI (OOUI-0.26.0); removed OOUI.
Jdforrester-WMF moved this task from OOUI-0.26.0 to Waiting for breaking release on the OOUI board.
Jdforrester-WMF edited projects, added OOUI; removed OOUI (OOUI-0.26.0).
Volker_E added a project: Patch-For-Review.Mar 27 2018, 1:00 AM
Volker_E moved this task from Backlog to Doing… on the UI-Standardization-Kanban board.Apr 3 2018, 8:37 PM
Jdforrester-WMF moved this task from Waiting for breaking release to OOUI-0.27.0 on the OOUI board.May 7 2018, 8:39 PM
Jdforrester-WMF edited projects, added OOUI (OOUI-0.27.0); removed OOUI.
Jdforrester-WMF closed this task as Resolved.May 7 2018, 8:41 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.May 7 2018, 8:48 PM

Change 405045 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] indicators: Remove 'alert', deprecated in v0.25.2

https://gerrit.wikimedia.org/r/405045

Volker_E mentioned this in T141801: WikimediaUI (Codex/OOUI) icon inventory (tracking).May 7 2018, 8:53 PM
Volker_E raised the priority of this task from High to Needs Triage.Jun 1 2018, 2:07 PM
Volker_E moved this task from Doing… to Done on the UI-Standardization-Kanban board.
• Esanders added a comment.Dec 11 2018, 2:13 PM

We missed a use in VE's template dialog, where it is used to indicate deprecated params.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits