[go: nahoru, domu]
Page MenuHomePhabricator
Create Task
Maniphest T200119

No page link notifications since around end of June
Closed, ResolvedPublic
Actions

Description

We are still collecting information, but several users of the German-language Wikipedia are reporting that they have not received any Echo notification that one of their articles was linked since end of June. (permalink to current state/live link (will be archived))

The two users who have confirmed they stopped receiving notifications are Hoefler50 and Lómelinde. We are still trying to find out if this affects all users or just a certain group.

Since the change to global preferences falls into this timeframe, it might be that this Echo problem is related.

Details

SubjectRepoBranchLines +/-
Fix page-linked notificationsmediawiki/extensions/Echomaster+3 -13
Restore passing of triggering user in edit updatesmediawiki/coremaster+7 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

Cirdan created this task.Jul 21 2018, 7:23 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 21 2018, 7:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Cirdan updated the task description. (Show Details)Jul 21 2018, 7:26 AM
Cirdan added a comment.Jul 21 2018, 10:11 AM

Examples of links added for which no notification was received by user Lómelinde:

articleLink addedmention
Carl Frederik Bricka28. Juni 2018yes
29. Juni 2018no
14. Juli 2018no
Alexander Brunschwig11. Juli 2018no
11. Juli 2018no
Cirdan renamed this task from No page link notifications on dewiki since around end of June (investigating) to No page link notifications on dewiki since around end of June.Jul 21 2018, 11:29 AM
Cirdan added a comment.Jul 22 2018, 3:45 PM

Another affected user is Diwas, who is the creator of the page "China" which according to them is linked to almost daily.

He last received a notification for this edit on June 28th.

Cirdan added a comment.Jul 31 2018, 7:00 PM

This might or might not be related to T200823: Site stats not updating when links added to pages, which is also about links added to pages not triggering events.

Reedy added a subtask: T200823: Site stats not updating when links added to pages.Jul 31 2018, 9:13 PM
Cirdan added a project: Regression.Aug 2 2018, 5:33 PM
Reedy closed subtask T200823: Site stats not updating when links added to pages as Resolved.Aug 3 2018, 2:11 PM
Reedy closed this task as Resolved.Aug 3 2018, 2:20 PM
Reedy claimed this task.
Reedy subscribed.

Underlying bug fixed. Stats updated

reedy@deploy1001:/srv/mediawiki-staging$ mwscript updateArticleCount.php --wiki=dewiki --update
Counting articles...[Fri Aug  3 14:19:26 2018] [hphp] [19768:7f6c132423c0:0:000001] [] SlowTimer [51170ms] at runtime/ext_mysql: slow query: SELECT /* SiteStatsInit::articles www-data@deploy... */  COUNT(DISTINCT page_id)  FROM `page`,`pagelinks`    WHERE page_namespace = '0' AND page_is_redirect = '0' AND (pl_from=page_id)  LIMIT 1  
found 2205826.
Updating site statistics table... done.
Cirdan added a comment.Aug 4 2018, 9:06 AM

@Reedy How certain are you that this fixes the problem? When should users expect to see notifications again?

Reedy added a comment.Aug 4 2018, 10:47 AM

Uhh. I thought this was a different task related to article counting :(

Dunno if this is actually fixed then...

Cirdan reopened this task as Open.Aug 4 2018, 11:30 AM

OK, let's keep this open and see what happens. We're still not sure if everybody is affected, but it's likely that this task here is also related to links to pages being added is not detected correctly.

Cirdan removed Reedy as the assignee of this task.Aug 4 2018, 6:50 PM
Catrope closed this task as Resolved.Aug 20 2018, 11:04 PM
Catrope claimed this task.
Catrope subscribed.

Closing this in the absence of any new reports in the 2+ weeks since @Reedy claimed to have fixed it. Please reopen if you find new occurrences.

Cirdan reopened this task as Open.Aug 21 2018, 9:19 AM

Hi @Catrope, there are still no page link notifications on dewiki. None of the users who complained has received any notifcations since the end of June, and as far as we can tell without surveying all users, nobody receives any page link notifications.

Reedy mistakenly took my comment that this bug might be related to the other one as meaning that there definitely is a connection and therefore closed this task without verifying that their update fixes this problem (which it doesn't).

Catrope added a comment.Aug 23 2018, 11:49 PM

You're right that something strange is happening. I can see a bunch of recent echo_event rows with event_type='page-linked', but none of them are referred to by rows in echo_notification. The most recent rows in echo_notification that refer to a page-linked event are from 2018-06-28, with the very last one being at 20:46:39 UTC. This lines up perfectly with:

20:46 marxarelli: Rolling 1.32.0-wmf.10 to group2 following fix and successful re-deploy to group1

So it looks like something happened in wmf.10 that broke this and hasn't been fixed since.

Cirdan added a comment.Aug 24 2018, 7:26 PM

Thanks for investigating! Any idea what could have caused this?

From looking through the task tagged with MW-1.32-release-notes_(WMF-deploy-2018-06-26_(1.32.0-wmf.10)) I don't see anything related to Echo or notifications. There seem to have been some changes to page saving which caused issues (T198483) and there is (T200823) which is related to detecting link updates, although from what you wrote, the fact that a link was added is recorded correctly.

Catrope added a comment.Aug 24 2018, 9:17 PM

Looks like page-linked notifications are broken everywhere. They also haven't been generated on English Wikipedia since June 28th, and I can even reproduce this exact same behavior (echo_event row but no echo_notification row) locally. That should make it easier to debug at least.

Catrope added a comment.Aug 24 2018, 9:54 PM

Somehow, the triggeringUser parameter to LinksUpdate/RefreshLinksJob is no longer being passed in. This means the page-linked event is saved to the database with the agent set to null, rather than the user that made the edit. EchoUserLocator::locateArticleCreator() then sees there is no agent and short-circuits, returning an empty list of recipients rather than looking up the page creator.

I can confirm this broke in MW core somewhere between wmf.8 and wmf.10, bisecting now.

Catrope added a comment.Aug 24 2018, 10:05 PM

Bisect blames rMWe8632ab0f626: [MCR] Factor PageUpdater out of WikiPage (gerrit 405015)

Jdforrester-WMF renamed this task from No page link notifications on dewiki since around end of June to No page link notifications since around end of June.Aug 24 2018, 10:11 PM
gerritbot subscribed.Aug 24 2018, 10:52 PM

Change 455259 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Echo@master] Fix page-linked notifications

https://gerrit.wikimedia.org/r/455259

gerritbot added a project: Patch-For-Review.Aug 24 2018, 10:52 PM
Catrope edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Aug 24 2018, 11:34 PM
Catrope moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Aug 26 2018, 6:27 PM

Change 455401 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/core@master] Restore passing of triggering user in edit updates

https://gerrit.wikimedia.org/r/455401

daniel subscribed.Aug 27 2018, 1:42 PM

Looks like I screwed this up. Thanks for finding the issue!

gerritbot added a comment.Aug 27 2018, 2:05 PM

Change 455401 merged by jenkins-bot:
[mediawiki/core@master] Restore passing of triggering user in edit updates

https://gerrit.wikimedia.org/r/455401

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 27 2018, 2:15 PM
Tgr closed this task as Resolved.Aug 27 2018, 2:37 PM
Tgr subscribed.

Given that this wasn't noticed for weeks, it's probably not severe enough to need a backport, so closing as resolved. Please reopen if that's not the case.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)).Aug 27 2018, 3:00 PM
gerritbot added a comment.Aug 28 2018, 12:14 AM

Change 455259 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Fix page-linked notifications

https://gerrit.wikimedia.org/r/455259

RandomDSdevel awarded a token.Oct 1 2018, 1:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits