Maniphest T204255

Introduce rewrite/second-try strategies
Closed, ResolvedPublic
Actions

Description

Currently the code to handle second-try-searches is rather add-hoc and make the work on adding the InitialSearchContext a bit awkward.
It relates to T156019 but this task is not about addressing all the possible search-options but to address second-try searches so that the code & concept behind the two strategies we support today can be "generalized" (language detection and DYM).

Details

Subject	Repo	Branch	Lines +/-
Generalize fallback & second-try methods	mediawiki/extensions/CirrusSearch	master	+1 K -166
Unify the CirrusSearch class with SearchQuery	mediawiki/extensions/CirrusSearch	master	+279 -109
Externalize language detector creation out of CirrusSearch	mediawiki/extensions/CirrusSearch	master	+220 -93

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Invalid		None	T235826 Introduce more complex and updated search syntax to allow power users and tools to do advanced searches
Open		None	T235827 [EPIC] new query parser is used in production
Open	PRODUCTION ERROR	None	T94814 Fix: "Warning: Search backend error during .. took .." (tracking)
Open		None	T185108 Refactor query parsing logic
Resolved		dcausse	T189880 Introduce SearchQuery
Resolved		dcausse	T204255 Introduce rewrite/second-try strategies

Event Timeline

dcausse triaged this task as Medium priority.Sep 13 2018, 3:24 PM

dcausse created this task.

Restricted Application edited projects, added Discovery-Search; removed Discovery-Search (Current work). · View Herald TranscriptSep 13 2018, 3:24 PM

dcausse moved this task from needs triage to Current work on the Discovery-Search board.Sep 13 2018, 3:25 PM

dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.

dcausse moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.

Change 460933 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Externalize language detector creation out of CirrusSearch

https://gerrit.wikimedia.org/r/460933

gerritbot added a project: Patch-For-Review.Sep 17 2018, 5:26 PM

Change 460933 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Externalize language detector creation out of CirrusSearch

https://gerrit.wikimedia.org/r/460933

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 20 2018, 5:00 PM

Change 465432 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Unify the CirrusSearch class with SearchQuery

https://gerrit.wikimedia.org/r/465432

Change 466932 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Generalize fallback & second tries method

https://gerrit.wikimedia.org/r/466932

dcausse moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Oct 12 2018, 4:34 PM

Change 465432 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Unify the CirrusSearch class with SearchQuery

https://gerrit.wikimedia.org/r/465432

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 6 2018, 7:02 PM

Change 466932 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Generalize fallback & second-try methods

https://gerrit.wikimedia.org/r/466932

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.8; 2018-12-11); removed MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Dec 3 2018, 7:00 PM

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Dec 3 2018, 7:33 PM

debt closed this task as Resolved.Dec 10 2018, 9:14 PM