[go: nahoru, domu]
Page MenuHomePhabricator
Create Task
Maniphest T207728

DropdownInput no longer reacts to keypresses when menu not shown
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Go to https://en.wikipedia.org/wiki/Special:ApiSandbox
  2. Focus the dropdown for action via tabbing.
  3. Press "q".

Expected (old behaviour of some weeks ago): "query" is selected.
Actual: Nothing happens. Or, if you have enabled "search as you type" in your browser, the browser search opens, and takes away both focus and current scroll position.

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.29.3mediawiki/coremaster+531 -359
DropdownWidget: Fix keypress handling when menu is closedoojs/uimaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Schnark created this task.Oct 23 2018, 9:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2018, 9:27 AM
• matmarex claimed this task.Oct 26 2018, 6:34 PM
• matmarex subscribed.

Broken by 119f10c5eff8245516e17c53cf2de28b58542cfa

gerritbot subscribed.Oct 26 2018, 6:34 PM

Change 469967 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] DropdownWidget: Fix keypress handling when menu is closed

https://gerrit.wikimedia.org/r/469967

gerritbot added a project: Patch-For-Review.Oct 26 2018, 6:34 PM
Volker_E moved this task from Backlog to OOUI-0.29.3 on the OOUI board.Oct 26 2018, 7:58 PM
Volker_E edited projects, added OOUI (OOUI-0.29.3); removed OOUI.
gerritbot added a comment.Oct 26 2018, 8:09 PM

Change 469967 merged by jenkins-bot:
[oojs/ui@master] DropdownWidget: Fix keypress handling when menu is closed

https://gerrit.wikimedia.org/r/469967

• matmarex added a parent task: T208341: Selecting a reason in delete/block dialog by keyboard doesn't work anymore.Oct 30 2018, 7:22 PM
Volker_E closed this task as Resolved.Nov 1 2018, 1:01 AM
Volker_E triaged this task as Medium priority.
Volker_E removed a project: Patch-For-Review.
gerritbot added a comment.Nov 1 2018, 2:58 AM

Change 470967 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.29.3

https://gerrit.wikimedia.org/r/470967

gerritbot added a project: Patch-For-Review.Nov 1 2018, 2:58 AM
gerritbot added a comment.Nov 1 2018, 3:59 AM

Change 470967 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.29.3

https://gerrit.wikimedia.org/r/470967

Volker_E removed a project: Patch-For-Review.Nov 2 2018, 7:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits