[go: nahoru, domu]
Page MenuHomePhabricator
Create Task
Maniphest T273576

Hard-deprecate IDatabase parameter for UserIdentity:getActorId()
Closed, ResolvedPublic
Actions

Description

User::getActorId() currently can take an IDatabase as a parameter. If it is provided and if the actor ID is not yet set, it will use the IDatabase to create an actor. This side effect causes complications now that UserIdentity supports foreign wikis. In some cases, UserIdentityValue::getActorId() has been passed an IDatabase as well.

Replace all occurrences of calling UserIdentity::getActorId() with an IDatabase (codesearch):

  • core
  • UserMerge
  • SocialProfile (not Wikimedia deployed)
  • Comments (not Wikimedia deployed)
  • VoteNY (not Wikimedia deployed)
  • WikiForum (not Wikimedia deployed)
  • Hard deprecate calling UserIdentity::getActorId() with an IDatabase

The replacement is relatively simple: MediaWikiServices::getInstance()->getActorNormalization()->acquireActorId( $user ) if the call is done in the context of the local wiki. For foreign wikis if's more complex - but let's first survey if it's ever needed.

Details

SubjectRepoBranchLines +/-
Replace User::getActorId($dbw) with ActorNormalization::acquireActorId()mediawiki/extensions/Commentsmaster+37 -4
Replace User::getActorId($dbw) with ActorNormalization::acquireActorId()mediawiki/extensions/WikiForummaster+80 -11
Replace User::getActorId($dbw) with ActorNormalization::acquireActorId()mediawiki/extensions/VoteNYmaster+10 -1
Replace User::getActorId($dbw) with ActorNormalization::acquireActorId()mediawiki/extensions/SocialProfilemaster+150 -16
Hard-deprecate IDatabase parameter for UserIdentity:getActorId()mediawiki/coremaster+68 -35
Replace User::getActorId($dbw) with ActorNormalization::acquireActorId()mediawiki/extensions/UserMergemaster+8 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

CCicalese_WMF created this task.Feb 2 2021, 3:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2021, 3:30 AM
CCicalese_WMF updated the task description. (Show Details)Feb 2 2021, 3:31 AM
• Pchelolo moved this task from Unsorted pile to UserStore pile on the Platform Team Workboards (MW Expedition) board.Feb 2 2021, 4:52 AM
• Pchelolo triaged this task as Medium priority.Feb 2 2021, 5:52 AM

Can't quite do it before we have registerActor from T272689 completed.

daniel raised the priority of this task from Medium to High.Feb 3 2021, 5:43 PM
daniel lowered the priority of this task from High to Medium.Feb 3 2021, 10:29 PM
• Pchelolo renamed this task from Do not call UserIdentity:getActorId() with an IDatabase parameter to Hard-deprecate IDatabase parameter for UserIdentity:getActorId().Feb 5 2021, 3:48 PM
• Pchelolo updated the task description. (Show Details)
• Pchelolo edited parent tasks, added: T273972: Survey cross-wiki User object creation and replace with ActorStore; removed: T222212: RevisionStore must not expose user IDs from a foreign wiki.Feb 5 2021, 3:56 PM
• Pchelolo assigned this task to CCicalese_WMF.Feb 8 2021, 5:36 PM
daniel raised the priority of this task from Medium to High.Feb 10 2021, 12:18 PM
CCicalese_WMF moved this task from UserStore pile to Doing on the Platform Team Workboards (MW Expedition) board.Feb 11 2021, 6:09 PM
CCicalese_WMF updated the task description. (Show Details)Feb 15 2021, 9:12 PM
gerritbot added a comment.Feb 15 2021, 9:39 PM

Change 664358 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/extensions/UserMerge@master] Hard-deprecate IDatabase parameter for UserIdentity:getActorId()

https://gerrit.wikimedia.org/r/664358

gerritbot added a project: Patch-For-Review.Feb 15 2021, 9:39 PM
gerritbot added a comment.Feb 15 2021, 10:26 PM

Change 664361 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/core@master] Hard-deprecate IDatabase parameter for UserIdentity:getActorId()

https://gerrit.wikimedia.org/r/664361

gerritbot added a comment.Feb 15 2021, 11:38 PM

Change 664364 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/extensions/SocialProfile@master] Hard-deprecate IDatabase parameter for UserIdentity:getActorId()

https://gerrit.wikimedia.org/r/664364

• Pchelolo moved this task from Doing to On the train on the Platform Team Workboards (MW Expedition) board.Feb 17 2021, 7:05 PM
gerritbot added a comment.Feb 17 2021, 7:11 PM

Change 664358 merged by jenkins-bot:
[mediawiki/extensions/UserMerge@master] Replace User::getActorId($dbw) with ActorNormalization::acquireActorId()

https://gerrit.wikimedia.org/r/664358

gerritbot added a comment.Feb 17 2021, 7:41 PM

Change 664361 merged by jenkins-bot:
[mediawiki/core@master] Hard-deprecate IDatabase parameter for UserIdentity:getActorId()

https://gerrit.wikimedia.org/r/664361

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 17 2021, 8:00 PM
gerritbot added a comment.Feb 17 2021, 11:51 PM

Change 664954 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/extensions/Comments@master] Replace User::getActorId($dbw) with ActorNormalization::acquireActorId()

https://gerrit.wikimedia.org/r/664954

gerritbot added a comment.Feb 17 2021, 11:57 PM

Change 664955 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/extensions/VoteNY@master] Replace User::getActorId($dbw) with ActorNormalization::acquireActorId()

https://gerrit.wikimedia.org/r/664955

gerritbot added a comment.Feb 18 2021, 12:05 AM

Change 664958 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/extensions/WikiForum@master] Replace User::getActorId($dbw) with ActorNormalization::acquireActorId()

https://gerrit.wikimedia.org/r/664958

CCicalese_WMF updated the task description. (Show Details)Feb 18 2021, 12:33 AM
CCicalese_WMF updated the task description. (Show Details)
gerritbot added a comment.Feb 19 2021, 8:55 AM

Change 664364 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Replace User::getActorId($dbw) with ActorNormalization::acquireActorId()

https://gerrit.wikimedia.org/r/664364

gerritbot added a comment.Feb 19 2021, 8:59 AM

Change 664955 merged by jenkins-bot:
[mediawiki/extensions/VoteNY@master] Replace User::getActorId($dbw) with ActorNormalization::acquireActorId()

https://gerrit.wikimedia.org/r/664955

gerritbot added a comment.Feb 19 2021, 8:59 AM

Change 664958 merged by jenkins-bot:
[mediawiki/extensions/WikiForum@master] Replace User::getActorId($dbw) with ActorNormalization::acquireActorId()

https://gerrit.wikimedia.org/r/664958

cicalese mentioned this in rESPR023c2e81636e: Replace User::getActorId($dbw) with ActorNormalization::acquireActorId().Feb 19 2021, 9:06 AM
gerritbot added a comment.Feb 24 2021, 1:44 PM

Change 664954 merged by jenkins-bot:
[mediawiki/extensions/Comments@master] Replace User::getActorId($dbw) with ActorNormalization::acquireActorId()

https://gerrit.wikimedia.org/r/664954

• Pchelolo closed this task as Resolved.Mar 5 2021, 6:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits