[go: nahoru, domu]

Page MenuHomePhabricator

"You have new messages" alert not showing on testwiki when logged out
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  1. Using an account, leave a message on your own IP's talk page on testwiki
  2. While logged out, visit https://test.wikipedia.org/w/api.php?action=query&meta=userinfo&uiprop=hasmsg to verify that step 1 worked
  3. While still logged out, open your network monitor and visit https://test.wikipedia.org/w/index.php?title=Talk:Foo&action=edit&safemode=1 or https://test.m.wikipedia.org/w/index.php?title=Talk:Foo&action=edit&safemode=1
  4. Verify that you aren't viewing cached content: X-Cache-Status: should be miss or pass. If it's hit, try another page.

What happens?:

No "you have new messages" alert (Orange/Peach Bar of Doom) is shown.

What should have happened instead?:

A "you have new messages" alert (Orange/Peach Bar of Doom) is shown.

Event Timeline

Tgr subscribed.

You only see the new message bar when you are viewing an uncached version of the cache. When an anonymous editor does something like an edit, they are marked as needing to see live pages so the edge cache lets them true. Since in case you did nothing to get marked, presumably you see the cached version.

Serving live views is expensive, and showing the message bar to random people on the same IP can be disruptive (some IPs are used by huge amounts of people). This behavior is not a bug.

(Unless you experience this on an uncached view - you can tell apart cached views from the response headers having X-Cache-Status: hit or something similar vs. miss or pass on uncached views. Please reopen if you see this on an uncached view.)

(Unless you experience this on an uncached view - you can tell apart cached views from the response headers having X-Cache-Status: hit or something similar vs. miss or pass on uncached views. Please reopen if you see this on an uncached view.)

I do. Reopened and refactored the task to indicate this. I should emphasize that I do see the message bar on enwiki and meta, at least on desktop.

Tgr triaged this task as High priority.EditedNov 11 2021, 8:03 PM

Thanks for checking!

This is a no-train week so testwiki, meta and enwiki all have the same software version. Maybe some extension/feature only enabled on testwiki is interfering? No idea what that could be.

Checked on testwiki - my IP user doesn't receive anything. When I check https://test.wikipedia.org/w/api.php?action=query&meta=userinfo&uiprop=hasmsg shows 0. I checked for a signed up user - all works as expected on testwiki, including the orange bar.

On betalabs I see the following after I log out. But if I (without logging in) would switch to any other page - there will no indication that I have any notifications.

Screen Shot 2021-11-12 at 10.34.43 AM.png (414×2 px, 93 KB)

Maybe some extension/feature only enabled on testwiki is interfering? No idea what that could be.

LiquidThreads maybe?

WikiLiquidThreads (according to InitialiseSettings.php)Message Bar
enNoYes
metaNoYes
testwiki"Frozen"No
test2wiki"Frozen"No
enwikinewsYesNo
enwikiquoteNoYes
enwiktionaryYesNo
enwikisourceNoYes

And maybe 359607fe9f17 is related:

                // If the user isn't using LQT on their talk page, bail out
                if ( !LqtDispatch::isLqtPage( $usertalk_t ) ) {
-                       return true;
+                       return false;
                }

It's installed but at Special:Version it's spelled "Liquid Threads" instead of "LiquidThreads". And I get no message bar. You can see the full list at https://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php. EIther wmgUseLiquidThreads or wmgLiquidThreadsFrozen force the extension to load.

Thanks for the thorough investigation @suffusion_of_yellow! You are correct, returning false from the GetNewMessagesAlert hook when the user does not use LiquidThreads seems like a bug.

MMiller_WMF added subscribers: ovasileva, MMiller_WMF.

@suffusion_of_yellow -- thanks for filing this task. I'm pinging @ovasileva from the team that worked on adding the bar to mobile so that they see this issue.

Change 739387 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/LiquidThreads@master] Fix new message alerts for users with non-LQT talk pages

https://gerrit.wikimedia.org/r/739387

Change 739387 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Fix new message alerts for users with non-LQT talk pages

https://gerrit.wikimedia.org/r/739387

I tried again on testwiki, enwiktionary, and enwikinews, and got an alert every time. Thanks for fixing this! Now where do we talk about disabling LiquidThreads on all WMF wikis?

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Using an account, leave a message on your own IP's talk page on beta
✅ AC1: While logged out, visit https://en.wikipedia.beta.wmflabs.org/wiki/api.php?action=query&meta=userinfo&uiprop=hasmsg to verify that step 1 worked

Screen Shot 2021-12-08 at 2.43.08 PM.png (522×821 px, 64 KB)

✅ AC2: While still logged out, open your network monitor and visit https://test.wikipedia.org/w/index.php?title=Talk:Foo&action=edit&safemode=1 or https://test.m.wikipedia.org/w/index.php?title=Talk:Foo&action=edit&safemode=1. Verify a "you have new messages" alert (Orange/Peach Bar of Doom) is shown.

Screen Shot 2021-12-08 at 2.58.13 PM.png (657×811 px, 127 KB)

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: testwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Using an account, leave a message on your own IP's talk page on beta
✅ AC1: While logged out, visit https://test.wikipedia.org/w/api.php?action=query&meta=userinfo&uiprop=hasmsg to verify that step 1 worked
Messages (see below) didn't appear until a message was sent to the user's IP talk page.

Screen Shot 2021-12-08 at 3.33.28 PM.png (461×817 px, 51 KB)

✅ AC2: While still logged out, open your network monitor and visit https://test.wikipedia.org/w/index.php?title=Talk:Foo&action=edit&safemode=1 or https://test.m.wikipedia.org/w/index.php?title=Talk:Foo&action=edit&safemode=1. Verify a "you have new messages" alert (Orange/Peach Bar of Doom) is shown.
The Permission Error is because I used VPN.

Screen Shot 2021-12-08 at 3.40.38 PM.png (675×819 px, 150 KB)

... Now where do we talk about disabling LiquidThreads on all WMF wikis?

T187487: LiquidThreads: code stewardship review

All done on this one, resolving