[go: nahoru, domu]

Page MenuHomePhabricator

Delete rows for growthexperiments-homepage-suggestededits-topics-enabled
Closed, ResolvedPublic

Description

The configuration was removed in T308209: Remove GEHomepageSuggestedEditsTopicsRequiresOptIn.

Acceptance criteria:

  • No more rows for growthexperiments-homepage-suggestededits-topics-enabled user property exist on any wiki

Related Objects

Event Timeline

kostajh changed the task status from Open to Stalled.May 13 2022, 9:13 AM
kostajh created this task.

Marking as stalled until T308209: Remove GEHomepageSuggestedEditsTopicsRequiresOptIn has been in production for two trains.

Urbanecm_WMF changed the task status from Stalled to Open.Jun 27 2022, 9:25 PM

Unstalling, as T308209 is in prod for 2+ weeks (as noted in T308309#7926623).

Looks like there's only a couple of those rows:

In [10]: WIKIS = utils.get_dblist('growthexperiments')

In [11]: dfs = []

In [12]: for wiki in WIKIS:
    ...:     dfs.append(mariadb.run('SELECT DATABASE() AS dbname, COUNT(*) AS cnt FROM user_properties WHERE up_property="growthexperiments-homepage-suggestededits-topics-enabled"', wiki))
    ...:

In [13]: df = pd.concat(dfs)
In [15]: df.sort_values('cnt', ascending=False).head()

Out[15]:
   dbname  cnt
0  kowiki    2
0  arwiki    2
0  viwiki    1
0  cswiki    1
0  abwiki    0

In [16]:

Let's just delete them manually. Let's work on T311460: Make userOptions.php capable of deleting user options too though, so we can work on more commonly used properties too.

Mentioned in SAL (#wikimedia-operations) [2022-06-27T21:34:56Z] <urbanecm> wikiadmin@10.64.48.109(kowiki)> delete from user_properties where up_property='growthexperiments-homepage-suggestededits-topics-enabled'; # T308309

Mentioned in SAL (#wikimedia-operations) [2022-06-27T21:35:01Z] <urbanecm> wikiadmin@10.64.48.109(arwiki)> delete from user_properties where up_property='growthexperiments-homepage-suggestededits-topics-enabled'; # T308309

Mentioned in SAL (#wikimedia-operations) [2022-06-27T21:35:55Z] <urbanecm> wikiadmin@10.64.48.109(viwiki)> delete from user_properties where up_property='growthexperiments-homepage-suggestededits-topics-enabled'; # T308309

Mentioned in SAL (#wikimedia-operations) [2022-06-27T21:36:06Z] <urbanecm> wikiadmin@10.64.16.184(cswiki)> delete from user_properties where up_property='growthexperiments-homepage-suggestededits-topics-enabled'; # T308309

Manual deletions are done:

[urbanecm@mwmaint1002 ~]$ sql kowiki --write

wikiadmin@10.64.48.109(kowiki)> select * from user_properties where up_property='growthexperiments-homepage-suggestededits-topics-enabled';
+---------+----------------------------------------------------------+----------+
| up_user | up_property                                              | up_value |
+---------+----------------------------------------------------------+----------+
|  XXXXXX | growthexperiments-homepage-suggestededits-topics-enabled | 1        |
|  XXXXXX | growthexperiments-homepage-suggestededits-topics-enabled | 1        |
+---------+----------------------------------------------------------+----------+
2 rows in set (0.001 sec)

wikiadmin@10.64.48.109(kowiki)> begin;
Query OK, 0 rows affected (0.000 sec)

wikiadmin@10.64.48.109(kowiki)> delete from user_properties where up_property='growthexperiments-homepage-suggestededits-topics-enabled';
Query OK, 2 rows affected (0.001 sec)

wikiadmin@10.64.48.109(kowiki)> commit;
Query OK, 0 rows affected (0.001 sec)

wikiadmin@10.64.48.109(kowiki)> Bye
[urbanecm@mwmaint1002 ~]$ sql arwiki --write

wikiadmin@10.64.48.109(arwiki)> select * from user_properties where up_property='growthexperiments-homepage-suggestededits-topics-enabled';
+---------+----------------------------------------------------------+----------+
| up_user | up_property                                              | up_value |
+---------+----------------------------------------------------------+----------+
|  XXXXXX | growthexperiments-homepage-suggestededits-topics-enabled | 1        |
|  XXXXXX | growthexperiments-homepage-suggestededits-topics-enabled | 1        |
+---------+----------------------------------------------------------+----------+
2 rows in set (0.002 sec)

wikiadmin@10.64.48.109(arwiki)> begin;
Query OK, 0 rows affected (0.000 sec)

wikiadmin@10.64.48.109(arwiki)> delete from user_properties where up_property='growthexperiments-homepage-suggestededits-topics-enabled';
Query OK, 2 rows affected (0.002 sec)

wikiadmin@10.64.48.109(arwiki)> commit;
Query OK, 0 rows affected (0.001 sec)

wikiadmin@10.64.48.109(arwiki)> Bye
[urbanecm@mwmaint1002 ~]$ sql viwiki --write

wikiadmin@10.64.48.109(viwiki)> select * from user_properties where up_property='growthexperiments-homepage-suggestededits-topics-enabled';
+---------+----------------------------------------------------------+----------+
| up_user | up_property                                              | up_value |
+---------+----------------------------------------------------------+----------+
|  XXXXXX | growthexperiments-homepage-suggestededits-topics-enabled | 1        |
+---------+----------------------------------------------------------+----------+
1 row in set (0.001 sec)

wikiadmin@10.64.48.109(viwiki)> begin;
Query OK, 0 rows affected (0.000 sec)

wikiadmin@10.64.48.109(viwiki)> delete from user_properties where up_property='growthexperiments-homepage-suggestededits-topics-enabled';
Query OK, 1 row affected (0.001 sec)

wikiadmin@10.64.48.109(viwiki)> commit;
Query OK, 0 rows affected (0.001 sec)

wikiadmin@10.64.48.109(viwiki)> Bye
[urbanecm@mwmaint1002 ~]$ sql cswiki --write

wikiadmin@10.64.16.184(cswiki)> select * from user_properties where up_property='growthexperiments-homepage-suggestededits-topics-enabled';
+---------+----------------------------------------------------------+----------+
| up_user | up_property                                              | up_value |
+---------+----------------------------------------------------------+----------+
|  XXXXXX | growthexperiments-homepage-suggestededits-topics-enabled | 1        |
+---------+----------------------------------------------------------+----------+
1 row in set (0.002 sec)

wikiadmin@10.64.16.184(cswiki)> begin;
Query OK, 0 rows affected (0.000 sec)

wikiadmin@10.64.16.184(cswiki)> delete from user_properties where up_property='growthexperiments-homepage-suggestededits-topics-enabled';
Query OK, 1 row affected (0.001 sec)

wikiadmin@10.64.16.184(cswiki)> commit;
Query OK, 0 rows affected (0.001 sec)

wikiadmin@10.64.16.184(cswiki)> Bye
[urbanecm@mwmaint1002 ~]$

Verification:

In [3]: WIKIS = utils.get_dblist('growthexperiments')

In [4]: dfs = []

In [5]: for wiki in WIKIS:
   ...:     dfs.append(mariadb.run('SELECT DATABASE() AS dbname, COUNT(*) AS cnt FROM user_properties WHERE up_property="growthexperiments-homepage-suggestededits-topics-enabled"', wiki))
   ...:

In [6]: df = pd.concat(dfs)

In [7]: df.sort_values('cnt', ascending=False).head()
Out[7]:
    dbname  cnt
0   abwiki    0
0  pagwiki    0
0  pihwiki    0
0  pflwiki    0
0  pdcwiki    0

Acceptance criteria verified => resolving the task.