[go: nahoru, domu]
Page MenuHomePhabricator
Create Task
Maniphest T317309

Create an API that renders the CirrusSearch indexable document based on a page_id and a revision id
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

As a search engineer I want to access the document that CirrusSearch will index for a particular page_id & revision_id.

Currently Cirrus exposes the cirrusbuilddoc property. Unfortunately it does not support selecting a revision. As we plan to fetch the CirrusSearch content while consuming EventBus page state streams we want to make sure that the revision we expect to read is the one that CirrusSearch will use to create its document.

We could possibly add a new optional parameter rev_id to the existing cirrusbuilddoc property or create a completely new API endpoint.

AC:

  • A MW API can be called to construct the CirrusSearch document for a particular revision id
  • The response should indicate if the revision has been found or (should not fallback to latest page revision)

Details

SubjectRepoBranchLines +/-
Use SearchDataForIndex2 hookmediawiki/extensions/GrowthExperimentsmaster+46 -11
Use SearchDataForIndex2 hookmediawiki/extensions/GeoDatamaster+82 -27
Make the doc building process revision basedmediawiki/extensions/CirrusSearchmaster+387 -97
Use use EntityHandler::getContentDataForSearchIndexmediawiki/extensions/WikibaseMediaInfomaster+217 -349
Use SearchDataForIndex2 and properperly pass the revision...mediawiki/extensions/Wikibasemaster+37 -4
Make the doc building for search aware of the revisionmediawiki/coremaster+105 -18
Make the doc building for search aware of the revisionmediawiki/extensions/Wikibasemaster+14 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

dcausse created this task.Sep 8 2022, 1:06 PM
• MPhamWMF moved this task from needs triage to ML & Data Pipeline on the Discovery-Search board.Sep 12 2022, 3:44 PM
dcausse mentioned this in T317202: Model the update document used by the CirrusSearch Update Pipeline.Sep 12 2022, 5:42 PM
pfischer subscribed.Sep 13 2022, 7:59 AM
dcausse claimed this task.Sep 14 2022, 11:48 AM
dcausse edited projects, added Discovery-Search (Current work); removed Epic, Discovery-Search.
• MPhamWMF set the point value for this task to 5.Sep 19 2022, 3:46 PM
• MPhamWMF moved this task from Incoming to In Progress on the Discovery-Search (Current work) board.
gerritbot added a comment.Sep 19 2022, 4:48 PM

Change 832957 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/core@master] Make the doc building for search aware of the revision

https://gerrit.wikimedia.org/r/832957

gerritbot added a project: Patch-For-Review.Sep 19 2022, 4:48 PM
gerritbot added a comment.Sep 19 2022, 5:13 PM

Change 833059 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/Wikibase@master] Make the doc building for search aware of the revision

https://gerrit.wikimedia.org/r/833059

gerritbot added a comment.Sep 20 2022, 1:33 PM

Change 833375 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/GeoData@master] Use SearchDataForIndex2 hook

https://gerrit.wikimedia.org/r/833375

gerritbot added a comment.Sep 20 2022, 2:06 PM

Change 833380 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/Wikibase@master] Use SearchDataForIndex2 and properperly pass the revision...

https://gerrit.wikimedia.org/r/833380

gerritbot added a comment.Sep 20 2022, 4:16 PM

Change 833419 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/GrowthExperiments@master] Use SearchDataForIndex2 hook

https://gerrit.wikimedia.org/r/833419

gerritbot added a comment.Sep 27 2022, 5:36 PM

Change 835664 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/WikibaseMediaInfo@master] Make the doc building process for search aware of the revision

https://gerrit.wikimedia.org/r/835664

gerritbot added a comment.Sep 28 2022, 2:56 PM

Change 832958 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/CirrusSearch@master] Make the doc building process revision based

https://gerrit.wikimedia.org/r/832958

dcausse moved this task from In Progress to Needs review on the Discovery-Search (Current work) board.Oct 4 2022, 8:33 AM
gerritbot added a comment.Oct 24 2022, 4:42 PM

Change 833059 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Make the doc building for search aware of the revision

https://gerrit.wikimedia.org/r/833059

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 24 2022, 5:00 PM
gerritbot added a comment.Oct 25 2022, 6:43 PM

Change 832957 merged by jenkins-bot:

[mediawiki/core@master] Make the doc building for search aware of the revision

https://gerrit.wikimedia.org/r/832957

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.8; 2022-10-31); removed MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 25 2022, 7:00 PM
gerritbot added a comment.Oct 25 2022, 10:51 PM

Change 833380 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SearchDataForIndex2 and properperly pass the revision...

https://gerrit.wikimedia.org/r/833380

gerritbot added a comment.Oct 26 2022, 7:28 PM

Change 835664 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Use use EntityHandler::getContentDataForSearchIndex

https://gerrit.wikimedia.org/r/835664

gerritbot added a comment.Oct 26 2022, 8:51 PM

Change 832958 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Make the doc building process revision based

https://gerrit.wikimedia.org/r/832958

gerritbot added a comment.Oct 27 2022, 4:22 PM

Change 833375 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Use SearchDataForIndex2 hook

https://gerrit.wikimedia.org/r/833375

dcausse moved this task from Needs review to To Be Deployed on the Discovery-Search (Current work) board.Oct 31 2022, 4:18 PM
gerritbot added a comment.Oct 31 2022, 8:22 PM

Change 833419 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Use SearchDataForIndex2 hook

https://gerrit.wikimedia.org/r/833419

dcausse moved this task from To Be Deployed to Needs Reporting on the Discovery-Search (Current work) board.Nov 7 2022, 4:08 PM
Gehel closed this task as Resolved.Nov 11 2022, 9:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits