[go: nahoru, domu]
Page MenuHomePhabricator
Create Task
Maniphest T328497

Remove unnecessary targets definitions
Closed, ResolvedPublic
Actions

Assigned To
Jdlrobson
Authored By
Jdlrobson
Jan 31 2023, 10:35 PM
Tags
Referenced Files
None
Subscribers
Aklapper
alistair3149
AntiCompositeNumber
• brooke
Catrope
Ciencia_Al_Poder
Florian
View All 27 Subscribers

Description

NOTE: Feel free to untag your project and create subtasks if needed.

In https://gerrit.wikimedia.org/r/c/mediawiki/core/+/865811 we updated the default for targets to be ["desktop", "mobile"]. This means that any extensions/skins defining this are now redundant and can remove these definitions,

The following query marks some of the offenders (regex to be improved later):
https://codesearch.wmcloud.org/search/?q=%22targets%22&i=nope&files=(extension%7Cskin).json&excludeFiles=&repos=

TODO

  • Remove the lines
  • Bump the MediaWiki required version to 1.40

Details

SubjectRepoBranchLines +/-
Merge branch 'master' into wmf_deploymediawiki/extensions/CentralNoticewmf_deploy+0 -0
Drop RL targets definitions from module class, and validation / error codemediawiki/extensions/Gadgetsmaster+2 -61
Drop RL targets definitions from module classmediawiki/extensions/UniversalLanguageSelectormaster+0 -48
Drop RL targets definitions from module definition, no longer honouredmediawiki/extensions/WikimediaEventsmaster+0 -1
Drop RL targets definitions from module classmediawiki/extensions/Translatemaster+11 -151
Turnstile: Drop RL targets definitions, no longer honouredmediawiki/extensions/ConfirmEditmaster+1 -5
Drop RL targets definitions from module class, no longer honouredmediawiki/extensions/VisualEditormaster+0 -4
Drop RL targets definitions from module definition, no longer honouredmediawiki/extensions/TemplateDatamaster+0 -1
Drop RL targets definitions from module definition, no longer honouredmediawiki/extensions/ContentTranslationmaster+0 -1
Drop RL targets definitions from module class, no longer honouredmediawiki/extensions/WikibaseLexememaster+0 -16
Drop RL targets definitions from module class, no longer honouredmediawiki/extensions/AdvancedSearchmaster+0 -5
Drop RL targets definitions from module class, no longer honouredmediawiki/extensions/Citoidmaster+0 -3
Drop RL targets definitions from module class, no longer honouredmediawiki/extensions/CentralNoticemaster+0 -15
tests: Remove call to Module::getTargetsmediawiki/extensions/QuickSurveysmaster+0 -1
Drop RL targets definitions from module definition, no longer honouredmediawiki/extensions/ConfirmEditmaster+0 -1
Drop RL targets definitions from module class, no longer honouredmediawiki/extensions/GlobalCssJsmaster+0 -7
Remove unnecessary targets definitions and bump required version to MW 1.40mediawiki/extensions/Babelmaster+2 -6
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/CentralNoticemaster+0 -44
*/extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/ConfirmEditmaster+4 -28
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/ORESmaster+1 -9
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/NavigationTimingmaster+0 -4
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/WebAuthnmaster+0 -20
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/DismissableSiteNoticemaster+1 -9
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/DiscussionToolsmaster+2 -18
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/CodeEditormaster+0 -20
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/MachineVisionmaster+1 -9
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/MediaSearchmaster+1 -9
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/WikibaseMediaInfomaster+0 -36
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/GlobalWatchlistmaster+0 -12
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/CharInsertmaster+0 -8
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/AbuseFiltermaster+1 -5
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/wikihieromaster+0 -4
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/timelinemaster+0 -4
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/VueTestmaster+4 -20
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/Scoremaster+0 -4
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/CentralAuthmaster+1 -17
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/SyntaxHighlight_GeSHimaster+0 -12
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/ArticlePlaceholdermaster+1 -5
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/FlaggedRevsmaster+1 -13
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/WikiEditormaster+0 -8
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/UploadWizardmaster+1 -17
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/WikimediaBadgesmaster+0 -4
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/Wikidata.orgmaster+0 -4
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/VisualEditormaster+0 -4
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/TitleBlacklistmaster+1 -9
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/OATHAuthmaster+0 -4
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/CategoryTreemaster+0 -8
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/ImageSuggestionsmaster+0 -4
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/WikimediaEventsmaster+0 -12
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/Quizmaster+2 -10
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/BetaFeaturesmaster+0 -8
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/InputBoxmaster+1 -5
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/SpamBlacklistmaster+1 -5
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/WikibaseQualityConstraintsmaster+0 -4
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/Thanksmaster+0 -16
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/GrowthExperimentsmaster+0 -8
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/Wikisourcemaster+0 -4
extension.json: Drop RL targets definitions, no longer honouredmediawiki/extensions/CampaignEventsmaster+0 -32
Remove unnecesary targets from RL module definitionsmediawiki/extensions/CodeEditormaster+0 -20
Remove unnecessary target defintions from TMH extension.jsonmediawiki/extensions/TimedMediaHandlermaster+3 -43
Remove unnecessary targets definitions from extension.jsonmediawiki/extensions/ChessBrowsermaster+0 -4
Bump MW dependency to >= 1.40.0mediawiki/extensions/Citemaster+1 -1
Targets no longer needed in Echomediawiki/extensions/Echomaster+1 -49
Targets no longer needed in Citemediawiki/extensions/Citemaster+3 -31
Targets no longer needed in TwoColConflictmediawiki/extensions/TwoColConflictmaster+0 -4
Targets no longer needed in EventLoggingmediawiki/extensions/EventLoggingmaster+0 -8
Remove unnecessary target definitionsmediawiki/extensions/Citoidmaster+1 -9
Targets are no longer necessarymediawiki/extensions/SearchVuemaster+0 -4
Remove deprecated "targets"mediawiki/extensions/AdvancedSearchmaster+0 -20
ResourceLoader: Define targets in a single locationmediawiki/coremaster+0 -14
Remove unnecessary targets definitionsmediawiki/extensions/ProofreadPagemaster+3 -35
Remove unnecessary targetsmediawiki/extensions/ContentTranslationmaster+14 -118
Remove unnecessary targetsmediawiki/extensions/VisualEditormaster+11 -247
Remove redundant targets definitionsmediawiki/extensions/MobileFrontendmaster+26 -66
Modules target desktop and mobile by default nowmediawiki/extensions/Mathmaster+2 -26
extension.json: Drop 'targets' definitions where they're now the defaultmediawiki/extensions/WikiLambdamaster+1 -17
Resources: Targets no longer necessarymediawiki/extensions/WikidataPageBannermaster+4 -20
Modules target desktop and mobile by default nowmediawiki/extensions/QuickSurveysmaster+1 -15
Targets no longer needed in RelatedArticlesmediawiki/extensions/RelatedArticlesmaster+2 -14
Targets no longer needed in NearbyPagesmediawiki/extensions/NearbyPagesmaster+1 -3
Targets no longer neededmediawiki/skins/MinervaNeuemaster+0 -41
Targets no longer neededmediawiki/skins/Vectormaster+0 -8
Remove unnecessary targets definitionsmediawiki/extensions/Wikistoriesmaster+0 -4
Remove targets definitions and limit page previews to ES6 browsersmediawiki/extensions/Popupsmaster+3 -3
Targets no longer neededmediawiki/skins/MonoBookmaster+0 -1
Remove unnecessary targets definitions from extension.jsonmediawiki/extensions/Scribuntomaster+1 -3
Resources: Remove redundant targets definitionsmediawiki/coremaster+0 -180
Remove unnecessary targets definitions from extension.jsonmediawiki/extensions/Kartographermaster+2 -90
Remove unnecessary targets definitions from extension.jsonmediawiki/extensions/ReadingListsmaster+1 -3
Adjust default targets in RL/Modulemediawiki/coremaster+1 -4
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.14; 2024-01-16); removed MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Jan 12 2024, 2:00 PM
gerritbot added a comment.Jan 12 2024, 2:09 PM

Change 990061 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990061

gerritbot added a comment.Jan 12 2024, 2:24 PM

Change 990114 merged by jenkins-bot:

[mediawiki/extensions/Wikisource@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990114

gerritbot added a comment.Jan 12 2024, 2:41 PM

Change 990090 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990090

gerritbot added a comment.Jan 12 2024, 2:41 PM

Change 990102 merged by jenkins-bot:

[mediawiki/extensions/Thanks@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990102

gerritbot added a comment.Jan 12 2024, 3:00 PM

Change 990110 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990110

gerritbot added a comment.Jan 12 2024, 3:38 PM

Change 990100 merged by jenkins-bot:

[mediawiki/extensions/SpamBlacklist@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990100

gerritbot added a comment.Jan 12 2024, 3:42 PM

Change 990092 merged by jenkins-bot:

[mediawiki/extensions/InputBox@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990092

gerritbot added a comment.Jan 12 2024, 3:42 PM

Change 990091 merged by jenkins-bot:

[mediawiki/extensions/ImageSuggestions@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990091

gerritbot added a comment.Jan 12 2024, 3:42 PM

Change 990113 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990113

gerritbot added a comment.Jan 12 2024, 3:42 PM

Change 990096 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990096

gerritbot added a comment.Jan 12 2024, 3:42 PM

Change 990062 merged by jenkins-bot:

[mediawiki/extensions/CategoryTree@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990062

Jdforrester-WMF mentioned this in rEISU97d36a04e68a: extension.json: Drop RL targets definitions, no longer honoured.Jan 12 2024, 3:43 PM
gerritbot added a comment.Jan 12 2024, 3:48 PM

Change 990059 merged by jenkins-bot:

[mediawiki/extensions/BetaFeatures@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990059

gerritbot added a comment.Jan 12 2024, 3:49 PM

Change 990103 merged by jenkins-bot:

[mediawiki/extensions/TitleBlacklist@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990103

gerritbot added a comment.Jan 12 2024, 3:49 PM

Change 990098 merged by jenkins-bot:

[mediawiki/extensions/Quiz@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990098

gerritbot added a comment.Jan 12 2024, 4:28 PM

Change 990105 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990105

gerritbot added a comment.Jan 12 2024, 4:40 PM

Change 990111 merged by jenkins-bot:

[mediawiki/extensions/Wikidata.org@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990111

gerritbot added a comment.Jan 12 2024, 4:43 PM

Change 990112 merged by jenkins-bot:

[mediawiki/extensions/WikimediaBadges@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990112

gerritbot added a comment.Jan 12 2024, 4:45 PM

Change 990106 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990106

gerritbot added a comment.Jan 12 2024, 4:45 PM

Change 990104 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990104

gerritbot added a comment.Jan 12 2024, 4:45 PM

Change 990101 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990101

gerritbot added a comment.Jan 12 2024, 4:45 PM

Change 990058 merged by jenkins-bot:

[mediawiki/extensions/ArticlePlaceholder@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990058

gerritbot added a comment.Jan 12 2024, 4:46 PM

Change 990088 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990088

gerritbot added a comment.Jan 12 2024, 4:46 PM

Change 990063 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990063

gerritbot added a comment.Jan 12 2024, 5:18 PM

Change 990099 merged by jenkins-bot:

[mediawiki/extensions/Score@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990099

gerritbot added a comment.Jan 12 2024, 5:18 PM

Change 990116 merged by jenkins-bot:

[mediawiki/extensions/wikihiero@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990116

gerritbot added a comment.Jan 12 2024, 5:18 PM

Change 990107 merged by jenkins-bot:

[mediawiki/extensions/VueTest@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990107

gerritbot added a comment.Jan 12 2024, 5:18 PM

Change 990115 merged by jenkins-bot:

[mediawiki/extensions/timeline@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990115

gerritbot added a comment.Jan 12 2024, 5:18 PM

Change 990065 merged by jenkins-bot:

[mediawiki/extensions/CharInsert@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990065

Jdforrester-WMF mentioned this in rEVTE122e5f54ae97: extension.json: Drop RL targets definitions, no longer honoured.Jan 12 2024, 5:19 PM
Jdforrester-WMF mentioned this in rEHIE0a992866117a: extension.json: Drop RL targets definitions, no longer honoured.
gerritbot added a comment.Jan 12 2024, 5:20 PM

Change 990057 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990057

gerritbot added a comment.Jan 12 2024, 5:20 PM

Change 990089 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990089

gerritbot added a comment.Jan 12 2024, 5:31 PM

Change 990109 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990109

gerritbot added a comment.Jan 12 2024, 5:31 PM

Change 990093 merged by jenkins-bot:

[mediawiki/extensions/MachineVision@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990093

gerritbot added a comment.Jan 12 2024, 5:31 PM

Change 990094 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990094

gerritbot added a comment.Jan 12 2024, 5:32 PM

Change 990086 merged by jenkins-bot:

[mediawiki/extensions/CodeEditor@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990086

gerritbot added a comment.Jan 12 2024, 5:32 PM

Change 990087 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990087

Iniquity removed a project: WikiEditor (2010).Jan 12 2024, 5:58 PM
gerritbot added a comment.Jan 12 2024, 6:17 PM

Change 990156 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/ConfirmEdit@master] */extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990156

gerritbot added a comment.Jan 12 2024, 6:23 PM

Change 990159 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/DismissableSiteNotice@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990159

gerritbot added a comment.Jan 12 2024, 6:39 PM

Change 990159 merged by jenkins-bot:

[mediawiki/extensions/DismissableSiteNotice@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990159

gerritbot added a comment.Jan 12 2024, 7:02 PM

Change 990108 merged by jenkins-bot:

[mediawiki/extensions/WebAuthn@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990108

gerritbot added a comment.Jan 12 2024, 10:52 PM

Change 990095 merged by jenkins-bot:

[mediawiki/extensions/NavigationTiming@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990095

gerritbot added a comment.Jan 12 2024, 10:52 PM

Change 990097 merged by jenkins-bot:

[mediawiki/extensions/ORES@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990097

gerritbot added a comment.Jan 12 2024, 10:54 PM

Change 990156 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] */extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990156

Jdforrester-WMF removed projects: Wikidata, Structured-Data-Backlog, Machine-Learning-Team, Data-Engineering, Timeless, All-and-every-Wikisource, MediaWiki-extensions-WikimediaEvents, MediaWiki-extensions-WikimediaBadges, WikiHiero, Wikibase-Quality-Constraints, WikibaseMediaInfo, VueTest, MediaWiki-extensions-UrlShortener, UploadWizard, TitleBlacklist, EasyTimeline, TimedMediaHandler, SpamBlacklist, SDAW-SearchVue, MediaWiki-extensions-Score, MediaWiki-extensions-Quiz, ORES, MediaWiki-extensions-OAuth, NavigationTiming, SDAW-MediaSearch, MachineVision, MediaWiki-extensions-InputBox, MediaWiki-extensions-FlaggedRevs, DismissableSiteNotice, DiscussionTools, MediaWiki-extensions-Disambiguator, CirrusSearch, CharInsert, MediaWiki-extensions-CentralAuth, MediaWiki-extensions-CategoryTree, BetaFeatures, ArticlePlaceholder, ConfirmEdit (CAPTCHA extension), CodeEditor, ExternalGuidance, MediaWiki-extensions-GlobalWatchlist, SyntaxHighlight.Jan 13 2024, 12:16 AM
Tacsipacsi changed the status of subtask T334376: Remove unnecessary targets definitions from Babel from Stalled to Open.Jan 13 2024, 11:53 AM
Universal_Omega added a project: Cosmos.Jan 13 2024, 4:59 PM
gerritbot added a comment.Jan 19 2024, 11:03 PM

Change 990064 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] extension.json: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/990064

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2024, 11:31 PM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.15; 2024-01-23); removed MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Jan 20 2024, 1:00 AM
gerritbot added a comment.Jan 22 2024, 1:35 PM

Change 906607 merged by jenkins-bot:

[mediawiki/extensions/Babel@master] Remove unnecessary targets definitions and bump required version to MW 1.40

https://gerrit.wikimedia.org/r/906607

Umherirrender closed subtask T334376: Remove unnecessary targets definitions from Babel as Resolved.Jan 22 2024, 5:54 PM
gerritbot added a comment.Jan 23 2024, 8:40 PM

Change 992497 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/VisualEditor@master] Drop RL targets definitions from module class, no longer honoured

https://gerrit.wikimedia.org/r/992497

gerritbot added a project: Patch-For-Review.Jan 23 2024, 8:40 PM
gerritbot added a comment.Jan 23 2024, 8:46 PM

Change 992500 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikibaseLexeme@master] Drop RL targets definitions from module class, no longer honoured

https://gerrit.wikimedia.org/r/992500

gerritbot added a comment.Jan 23 2024, 8:48 PM

Change 992501 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GlobalCssJs@master] Drop RL targets definitions from module class, no longer honoured

https://gerrit.wikimedia.org/r/992501

gerritbot added a comment.Jan 23 2024, 8:50 PM

Change 992502 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AdvancedSearch@master] Drop RL targets definitions from module class, no longer honoured

https://gerrit.wikimedia.org/r/992502

gerritbot added a comment.Jan 23 2024, 8:51 PM

Change 992503 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralNotice@master] Drop RL targets definitions from module class, no longer honoured

https://gerrit.wikimedia.org/r/992503

gerritbot added a comment.Jan 23 2024, 8:51 PM

Change 992504 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Citoid@master] Drop RL targets definitions from module class, no longer honoured

https://gerrit.wikimedia.org/r/992504

gerritbot added a comment.Jan 23 2024, 8:52 PM

Change 992505 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ConfirmEdit@master] Drop RL targets definitions from module definition, no longer honoured

https://gerrit.wikimedia.org/r/992505

gerritbot added a comment.Jan 23 2024, 8:55 PM

Change 992527 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ContentTranslation@master] Drop RL targets definitions from module definition, no longer honoured

https://gerrit.wikimedia.org/r/992527

gerritbot added a comment.Jan 23 2024, 8:56 PM

Change 992528 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TemplateData@master] Drop RL targets definitions from module definition, no longer honoured

https://gerrit.wikimedia.org/r/992528

gerritbot added a comment.Jan 23 2024, 8:56 PM

Change 992529 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/UniversalLanguageSelector@master] Drop RL targets definitions from module class, no longer honoured

https://gerrit.wikimedia.org/r/992529

gerritbot added a comment.Jan 23 2024, 9:04 PM

Change 992532 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/QuickSurveys@master] tests: Remove call to Module::getTargets

https://gerrit.wikimedia.org/r/992532

Umherirrender closed subtask T351001: Remove unnecessary ResourceLoader targets definitions from CampaignEvents as Resolved.Jan 23 2024, 10:24 PM
gerritbot added a comment.Jan 23 2024, 10:26 PM

Change 992505 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Drop RL targets definitions from module definition, no longer honoured

https://gerrit.wikimedia.org/r/992505

gerritbot added a comment.Jan 23 2024, 10:27 PM

Change 992501 merged by jenkins-bot:

[mediawiki/extensions/GlobalCssJs@master] Drop RL targets definitions from module class, no longer honoured

https://gerrit.wikimedia.org/r/992501

gerritbot added a comment.Jan 23 2024, 10:27 PM

Change 992532 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] tests: Remove call to Module::getTargets

https://gerrit.wikimedia.org/r/992532

Umherirrender closed subtask T342517: [WD-ORG] Remove unnecessary targets definitions - wikidata as Resolved.Jan 23 2024, 10:29 PM
gerritbot added a comment.Jan 23 2024, 10:30 PM

Change 992503 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Drop RL targets definitions from module class, no longer honoured

https://gerrit.wikimedia.org/r/992503

gerritbot added a comment.Jan 23 2024, 10:33 PM

Change 992502 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Drop RL targets definitions from module class, no longer honoured

https://gerrit.wikimedia.org/r/992502

gerritbot added a comment.Jan 23 2024, 10:33 PM

Change 992504 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Drop RL targets definitions from module class, no longer honoured

https://gerrit.wikimedia.org/r/992504

gerritbot added a comment.Jan 23 2024, 10:51 PM

Change 992500 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Drop RL targets definitions from module class, no longer honoured

https://gerrit.wikimedia.org/r/992500

gerritbot added a comment.Jan 23 2024, 11:00 PM

Change 992544 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ConfirmEdit@master] Turnstile: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/992544

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.16; 2024-01-30); removed MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).Jan 23 2024, 11:00 PM
gerritbot added a comment.Jan 23 2024, 11:07 PM

Change 992545 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikimediaEvents@master] Drop RL targets definitions from module definition, no longer honoured

https://gerrit.wikimedia.org/r/992545

gerritbot added a comment.Jan 23 2024, 11:16 PM

Change 992546 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Translate@master] Drop RL targets definitions from module class

https://gerrit.wikimedia.org/r/992546

gerritbot added a comment.Jan 23 2024, 11:16 PM

Change 992527 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Drop RL targets definitions from module definition, no longer honoured

https://gerrit.wikimedia.org/r/992527

gerritbot added a comment.Jan 23 2024, 11:16 PM

Change 992528 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Drop RL targets definitions from module definition, no longer honoured

https://gerrit.wikimedia.org/r/992528

gerritbot added a comment.Jan 23 2024, 11:37 PM

Change 992497 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Drop RL targets definitions from module class, no longer honoured

https://gerrit.wikimedia.org/r/992497

gerritbot added a comment.Jan 24 2024, 12:11 AM

Change 992546 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Drop RL targets definitions from module class

https://gerrit.wikimedia.org/r/992546

gerritbot added a comment.Jan 24 2024, 12:11 AM

Change 992544 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Turnstile: Drop RL targets definitions, no longer honoured

https://gerrit.wikimedia.org/r/992544

gerritbot added a comment.Jan 24 2024, 12:11 AM

Change 992545 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Drop RL targets definitions from module definition, no longer honoured

https://gerrit.wikimedia.org/r/992545

gerritbot added a comment.Jan 24 2024, 3:27 AM

Change 992529 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Drop RL targets definitions from module class

https://gerrit.wikimedia.org/r/992529

gerritbot added a comment.Jan 24 2024, 5:11 PM

Change 992761 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/Gadgets@master] Drop RL targets definitions from module class, and validation / error code

https://gerrit.wikimedia.org/r/992761

gerritbot added a comment.Jan 24 2024, 6:06 PM

Change 992761 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Drop RL targets definitions from module class, and validation / error code

https://gerrit.wikimedia.org/r/992761

Jdforrester-WMF removed projects: Patch-For-Review, MediaWiki-extensions-Translate, MediaWiki-extensions-CentralNotice, UniversalLanguageSelector.Jan 24 2024, 6:16 PM
Jdforrester-WMF moved this task from Uncategorized to Clean-Up on the Technical-Debt (RW-Tech-Debt) board.
Jdforrester-WMF added a comment.Jan 24 2024, 6:19 PM

Per extension search and PHP array search this appears to now be done for all Wikimedia production code (just waiting for the irregular production branching of CentralNotice). Great work, all!

For non-Wikimedia-production code, there are 86 and 51 hits, respectively (with some false positives).

Jdforrester-WMF updated the task description. (Show Details)Jan 24 2024, 6:19 PM
Jdlrobson closed this task as Resolved.Jan 26 2024, 9:16 PM
Jdlrobson claimed this task.

Thanks James! I think we should close out this ticket as some of the remaining non-production code may not be maintained.
I've updated https://www.mediawiki.org/wiki/ResourceLoader/Writing_a_mobile_friendly_ResourceLoader_module with improved guidelines.

Xaosflux subscribed.Jan 29 2024, 7:39 PM
gerritbot added a comment.Mon, Jul 8, 8:31 AM

Change #1052668 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy

https://gerrit.wikimedia.org/r/1052668

gerritbot added a project: Patch-For-Review.Mon, Jul 8, 8:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits