[go: nahoru, domu]
Page MenuHomePhabricator
Create Task
Maniphest T329982

Logged-out user doesn't have timely warnings in editing mode ("View source" button still opens editor)
Closed, ResolvedPublic
Actions

Description

Scenario 1:

  • anon user clicks on Edit source button on a page, e.g. title=Z10147&action=edit
  • a user can type/change some of the fields - the Publish button becomes active
  • upon clicking on it a user is presented with a dialog to enter the info

Screen Shot 2023-02-17 at 2.11.44 PM.png (846×1 px, 103 KB)

  • a user types some text and clicks the Publish button only to be informed that edits cannot be saved.

Screen Shot 2023-02-17 at 2.11.56 PM.png (1×1 px, 116 KB)

What should have happened instead?:

  • users without permissions to edit should be informed immediately.
  • entering text/changing text in the fields should not be allowed
  • sufficient explanation of who can edit should be given. Currently the page informs that "Everyone can edit the labels." and "Only users with special permissions" has not yet been implemented as a link.

Details

SubjectRepoBranchLines +/-
About widget: Tie disabled state of edit pencil button to canEditObject methodmediawiki/extensions/WikiLambdawmf/1.41.0-wmf.19+13 -1
About widget: Tie disabled state of edit pencil button to canEditObject methodmediawiki/extensions/WikiLambdamaster+13 -1
Hide 'view source' links, they're pointless for our content typemediawiki/extensions/WikiLambdamaster+22 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Feb 17 2023, 10:31 PM
DVrandecic moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Feb 21 2023, 7:33 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready: G6. Stable & secure on the Abstract Wikipedia team (Phase θ – Throttling) board.Feb 21 2023, 7:34 PM
Jdforrester-WMF added a comment.Apr 4 2023, 3:06 PM

The button is now called "View source" but goes to action=edit; we should show a message but load the regular view not the editor in this case, I guess?

Jdforrester-WMF renamed this task from Anon user doesn't have timely warnings in editing mode to Logged-out user doesn't have timely warnings in editing mode ("View source" button still opens editor).Apr 10 2023, 8:08 PM
Etonkovidova mentioned this in T334364: [QA task] Testing UI workflows .Apr 10 2023, 9:18 PM
Jdforrester-WMF added a parent task: T334364: [QA task] Testing UI workflows .Apr 11 2023, 2:43 PM
Jdforrester-WMF moved this task from Phase θ – Throttling to Phase λ – Launch on the Abstract Wikipedia team board.Jun 16 2023, 9:03 AM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase λ – Launch); removed Abstract Wikipedia team (Phase θ – Throttling).
Jdforrester-WMF moved this task from Incoming to Engineering tasks on the Abstract Wikipedia team (Phase λ – Launch) board.Jun 16 2023, 9:38 AM
Jdforrester-WMF added a comment.Jul 6 2023, 1:55 PM

Probably best for now to just hide the view-source button.

Etonkovidova added a comment.Jul 12 2023, 10:38 PM

Re-checked in wikifunctions betalabs

  • anon users see "View source" and can click on it
  • "Publish" button is displayed as active and can be clicked without making any edits
  • upon clicking on it, anon users will see:

Screen Shot 2023-07-12 at 3.37.50 PM.png (1×1 px, 134 KB)

gerritbot added a comment.Jul 13 2023, 12:51 AM

Change 937558 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Hide 'view source' links, they're pointless for our content type

https://gerrit.wikimedia.org/r/937558

gerritbot added a project: Patch-For-Review.Jul 13 2023, 12:51 AM
gerritbot added a comment.Jul 17 2023, 7:45 PM

Change 937558 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Hide 'view source' links, they're pointless for our content type

https://gerrit.wikimedia.org/r/937558

Jdforrester-WMF moved this task from Engineering tasks to QA needed on the Abstract Wikipedia team (Phase λ – Launch) board.Jul 17 2023, 7:53 PM
Jdforrester-WMF claimed this task.Jul 17 2023, 8:00 PM

OK, if you go as a logged-out user to an uncached page you'll got no "View source" link, so there's no primary way to edit. Next step is to disable the 'edit' pencil when logged out. There's still a problem if you manually got to ?action=edit, but I think that's fine.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 17 2023, 8:00 PM
Jdforrester-WMF moved this task from QA needed to In progress on the Abstract Wikipedia team (Phase λ – Launch) board.Jul 17 2023, 8:02 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 17 2023, 8:10 PM
gerritbot added a comment.Jul 17 2023, 11:22 PM

Change 938951 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] About widget: Tie disabled state of edit pencil button to canEdit prop

https://gerrit.wikimedia.org/r/938951

gerritbot added a project: Patch-For-Review.Jul 17 2023, 11:22 PM
Jdforrester-WMF moved this task from In progress to QA needed on the Abstract Wikipedia team (Phase λ – Launch) board.Jul 24 2023, 8:51 PM
gerritbot added a comment.Jul 25 2023, 3:40 PM

Change 938951 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] About widget: Tie disabled state of edit pencil button to canEditObject method

https://gerrit.wikimedia.org/r/938951

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.20; 2023-08-01); removed MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 25 2023, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 25 2023, 4:10 PM
DVrandecic closed this task as Resolved.Jul 26 2023, 1:20 AM
DVrandecic subscribed.

Yep, no Edit link visible anymore. Works for me!

gerritbot added a comment.Jul 26 2023, 9:15 AM

Change 941849 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.19] About widget: Tie disabled state of edit pencil button to canEditObject method

https://gerrit.wikimedia.org/r/941849

gerritbot added a project: Patch-For-Review.Jul 26 2023, 9:15 AM
gerritbot added a comment.Jul 26 2023, 12:41 PM

Change 941849 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.19] About widget: Tie disabled state of edit pencil button to canEditObject method

https://gerrit.wikimedia.org/r/941849

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.19; 2023-07-25); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 26 2023, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 26 2023, 1:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits