fix-stagging-perms errors out with "find: paths must precede expression: `group'"
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm
	Jun 5 2023, 8:21 PM

Description

While fixing a permission error on the deployment host earlier today, I noticed the script errors out:

[urbanecm@deploy1002 ~]$ sudo /usr/local/sbin/fix-staging-perms
find: paths must precede expression: `group'

This means the script is unable to change the group owner for /srv/patches. This happens because of a missing dash in the script.

In addition to this, I noticed that the group owner of /srv/patches changed to deployment (this may or may not be the case for /srv/mediawiki-staging before I ran the fixing script and changed it to wikidev). Can someone confirm the group owner for those two paths should still be wikidev?

Details

	Subject	Repo	Branch	Lines +/-
	fix-staging-perms: Change group owner to deployment	operations/puppet	production	+4 -4
	fix-stagging-perms: Fix group owner change for /srv/patches	operations/puppet	production	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T338205: Scap train-presync failed to prepare 1.41.0-wmf.12
Mentioned Here: T338205: Scap train-presync failed to prepare 1.41.0-wmf.12

Event Timeline

Urbanecm created this task.Jun 5 2023, 8:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2023, 8:21 PM

Change 927269 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/puppet@production] fix-stagging-perms: Fix group owner change for /srv/patches

https://gerrit.wikimedia.org/r/927269

gerritbot added a project: Patch-For-Review.Jun 5 2023, 8:29 PM

Change 927269 merged by Dzahn:

[operations/puppet@production] fix-stagging-perms: Fix group owner change for /srv/patches

https://gerrit.wikimedia.org/r/927269

Mentioned in SAL (#wikimedia-operations) [2023-06-05T20:47:54Z] <urbanecm> [urbanecm@deploy1002 ~]$ sudo /usr/local/sbin/fix-staging-perms # verify T338180 fix

deployed in puppet and now:

[deploy1002:~] $ /usr/local/sbin/fix-staging-perms
[deploy1002:~] $

Maintenance_bot removed a project: Patch-For-Review.Jun 5 2023, 9:10 PM

Urbanecm closed this task as Resolved.Jun 5 2023, 9:14 PM

Urbanecm claimed this task.

Restricted Application added a project: User-Urbanecm. · View Herald TranscriptJun 5 2023, 9:14 PM

That one might have caused or sounds related to the train blocker T338205: Scap train-presync failed to prepare 1.41.0-wmf.12.

Change 927584 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/puppet@production] fix-staging-perms: Change group owner to deployment

https://gerrit.wikimedia.org/r/927584

gerritbot added a project: Patch-For-Review.Jun 6 2023, 8:36 AM

Change 927584 merged by Jcrespo: