[go: nahoru, domu]

Page MenuHomePhabricator

[betalabs] Section level image quality gate - daily limit applied incorrectly
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

  • Make the number of section image edits exceed The maximum number of "Add an image to an article section" suggested tasks a newcomer can complete daily set on Special:EditGrowthConfig page.

What happens?:
Checked on two wikis:

  • cswiki beta
    • a user doesn't see "More ways to edit" post-edit dialog. The normal post-edit dialog appears. However, when a user clicks on the next task - "Suggestions are no longer available" dialog will be displayed, along with the Console error:

Screen Shot 2023-06-06 at 2.46.21 PM.png (1×2 px, 870 KB)

You've exceeded your rate limit. Please wait some time and try again.
jQuery runScript cssHandle flushCssBuffer
  • on Special:Homepage a user will see
Screen Shot 2023-06-06 at 12.45.12 PM.png (896×1 px, 106 KB)
instead of, e.g.
Screen Shot 2023-06-06 at 2.51.53 PM.png (938×1 px, 165 KB)
  • after that, any user on cswiki beta will get You've exceeded your rate limit... message.

I checked

  • users who did not make edits for a really long time
  • users who just enable Homepage
  • new users
  • eswiki beta
    • the same behavior

Note: the other daily limits work as expected.

Event Timeline

Etonkovidova renamed this task from [betalabs] Add section level image quality gate - daily limit applied incorrectly to [betalabs] Section level image quality gate - daily limit applied incorrectly .Jun 6 2023, 11:33 PM

The task description says "daily limit applied incorrectly". Is there an error in the logic, or is the task only about the message not getting translated?

Change 928453 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Section images: Fix quality gate error i18n key

https://gerrit.wikimedia.org/r/928453

Change 928453 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Section images: Fix quality gate error i18n key

https://gerrit.wikimedia.org/r/928453

Change 928480 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Section images: Fix post-edit quality gate check

https://gerrit.wikimedia.org/r/928480

Change 928480 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Section images: Fix post-edit quality gate check

https://gerrit.wikimedia.org/r/928480

Checked on betalabs - the issue is fixed:

Screen Shot 2023-06-09 at 11.04.00 AM.png (1×1 px, 162 KB)
Screen Shot 2023-06-09 at 11.03.21 AM.png (744×1 px, 196 KB)