Description
Description
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | Rosalie_WMDE | T347865 🗑️Ask for feedback before deleting a WB instance to ask "why" | |||
Open | Rosalie_WMDE | T362609 🗑️Design the frontend for the Delete wikibase card |
Event Timeline
Comment Actions
Hey @Rosalie_WMDE ! Looks great to me! I found three small spacing issues:
- The spacing between the card text and the beginning of the checkboxes is currently too large. It should be 16px
- The spacing between the last checkbox and the label of the text field is too large. Should be 8px.
- The spacing between the text field and the buttons below is too large. Should be 8px.
Please check the figma specs for details and let me know if you have any questions. Thanks!
Comment Actions
Is this ready for an engineer to look at now or are you two still getting the design correct?
Comment Actions
My understanding from yesterday's daily is that it's waiting for an engineering review. at least i don't have it on my todo so please correct me if i should be looking at something @Rosalie_WMDE
Comment Actions
I'm off tomorrow; happy to look again on Monday but feel free to have someone else take a look on Friday