[go: nahoru, domu]
Page MenuHomePhabricator
Create Task
Maniphest T363084

Remove usage of MediaWiki's JsonBodyValidator from Wikibase REST API
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

As per T361995 JsonBodyValidator from Mediawiki REST API is discontinued in favor of a new mechanism (T358560)

Wikibase REST API should stop using the deprecated class.

Implementation notes:

  • for each POST/PUT/PATCH/DELETE route handler
    • remove getBodyValidator
    • move any field definitions that were previously in getBodyValidator to getBodyParamSettings
    • remove assertContentType and move the expected content types to getSupportedRequestTypes()
    • override Handler::validate() and add assertValidTopLevelTypes check to it (see example patch)
    • adjusts e2e tests according to the new expected responses
    • see https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1049935 for an example
  • remove TypeValidatingJsonBodyValidator
  • add application/json-patch+json to any PATCH endpoint e2e tests that are missing it, see e.g. repo/rest-api/tests/mocha/api-testing/PatchPropertyStatementTest.js once https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1049848 is merged

Details

SubjectRepoBranchLines +/-
REST: Remove usage of JsonBodyValidatormediawiki/extensions/Wikibasemaster+281 -131
REST: Remove usage of JsonBodyValidatormediawiki/extensions/Wikibasemaster+50 -22
REST: Remove usage of JsonBodyValidatormediawiki/extensions/Wikibasemaster+91 -49
REST: Remove use of JsonBodyValidator in SetItemLabelRouteHandlermediawiki/extensions/Wikibasemaster+17 -15
REST: Remove use of JsonBodyValidator in SetPropertyLabelRouteHandlermediawiki/extensions/Wikibasemaster+17 -12
REST: Remove usage of JsonBodyValidatormediawiki/extensions/Wikibasemaster+67 -87
REST: Remove usage of JsonBodyValidator in sitelinks edit route handlersmediawiki/extensions/Wikibasemaster+69 -62
REST: Remove usage of JsonBodyValidator in PatchItemRouteHandlermediawiki/extensions/Wikibasemaster+33 -20
REST: Remove usage of JsonBodyValidatormediawiki/extensions/Wikibasemaster+36 -38
REST: Refactor PATCH route handlers validationmediawiki/extensions/Wikibasemaster+80 -21
REST: Refactor edit route handlers validationmediawiki/extensions/Wikibasemaster+16 -18
REST: Refactor AddPropertyStatement and AddPropertyAliasesInLanguage route handlers validationmediawiki/extensions/Wikibasemaster+20 -16
REST: Refactor AddItemStatementRouteHandler validationmediawiki/extensions/Wikibasemaster+10 -8
REST: Remove usage of JsonBodyValidatormediawiki/extensions/Wikibasemaster+60 -51
REST: Remove use of JsonBodyValidatormediawiki/extensions/Wikibasemaster+65 -20
REST: Remove usage of JsonBodyValidator in PatchItemDescriptionsRouteHandlermediawiki/extensions/Wikibasemaster+18 -22
REST: Remove usage of JsonBodyValidator in PatchItemAliasesRouteHandlermediawiki/extensions/Wikibasemaster+18 -22
REST: Remove usage of JsonBodyValidator in CreateItemRouteHandlermediawiki/extensions/Wikibasemaster+37 -13
REST: Remove usage of JsonBodyValidator in PatchItemLabelsRouteHandlermediawiki/extensions/Wikibasemaster+18 -22
REST: Remove usage of JsonBodyValidatormediawiki/extensions/Wikibasemaster+127 -40
REST: Remove usage of JsonBodyValidator in AddItemAliasesInLanguageRouteHandlermediawiki/extensions/Wikibasemaster+66 -23
REST: Use custom top-level field validationmediawiki/extensions/Wikibasemaster+148 -12
REST: Remove usage of JsonBodyValidator in AddItemStatementRouteHandlermediawiki/extensions/Wikibasemaster+20 -32
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-leszek created this task.Apr 22 2024, 9:19 AM
ashley renamed this task from Remove usege of Mediawiki's JsonBodyValidator from Wikibase REST API to Remove usage of MediaWiki's JsonBodyValidator from Wikibase REST API.Apr 22 2024, 8:08 PM
Ifrahkhanyaree_WMDE moved this task from Incoming tickets outside WPP to Backlog on the Wikibase Product Platform Team WPP board.Apr 23 2024, 8:09 AM
Ifrahkhanyaree_WMDE moved this task from Backlog to Polished on the Wikibase Product Platform Team WPP board.Apr 23 2024, 8:48 AM
gerritbot added a comment.May 8 2024, 3:58 AM

Change #1028919 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in AddItemStatementRouteHandler

https://gerrit.wikimedia.org/r/1028919

gerritbot added a project: Patch-For-Review.May 8 2024, 3:58 AM
Jakob_WMDE updated the task description. (Show Details)May 8 2024, 7:25 AM
Ifrahkhanyaree_WMDE set the point value for this task to 8.May 15 2024, 10:23 AM
Ifrahkhanyaree_WMDE moved this task from Polished to Ready for planning on the Wikibase Product Platform Team WPP board.
daniel added a parent task: T366833: REST: Request Body Validation (tracking).Jun 6 2024, 7:02 PM
WMDE-leszek merged a task: T367395: Wikibase: stop using JsonBodyValidator in REST handlers.Jun 13 2024, 1:00 PM
WMDE-leszek added a parent task: T367394: REST: Stop using getParamSettings for body parameters.
WMDE-leszek added a subscriber: Michael.
Jakob_WMDE updated the task description. (Show Details)Jun 20 2024, 12:48 PM
gerritbot added a comment.Jun 20 2024, 1:52 PM

Change #1047481 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Use custom top-level field validation

https://gerrit.wikimedia.org/r/1047481

Jakob_WMDE moved this task from Ready for planning to Sprint 22 on the Wikibase Product Platform Team WPP board.Jun 20 2024, 1:52 PM
Jakob_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 22); removed Wikibase Product Platform Team WPP.
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 22) board.
Jakob_WMDE mentioned this in T368054: Look into ways to avoid HttpException for top-level validation.Jun 20 2024, 2:13 PM
daniel mentioned this in T361995: Remove usage of JsonBodyValidator from extensions.Jun 21 2024, 8:13 AM
daniel added a project: MW-Interfaces-Team.
daniel moved this task from Incoming (Needs Triage) to Radar (other teams work) on the MW-Interfaces-Team board.
gerritbot added a comment.Jun 23 2024, 5:53 PM

Change #1048887 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in AddItemAliasesInLanguageRouteHandler

https://gerrit.wikimedia.org/r/1048887

gerritbot added a comment.Jun 24 2024, 9:01 AM

Change #1049100 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator

https://gerrit.wikimedia.org/r/1049100

gerritbot added a comment.Jun 24 2024, 3:11 PM

Change #1028919 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in AddItemStatementRouteHandler

https://gerrit.wikimedia.org/r/1028919

gerritbot added a comment.Jun 24 2024, 3:11 PM

Change #1047481 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use custom top-level field validation

https://gerrit.wikimedia.org/r/1047481

gerritbot added a comment.Jun 24 2024, 3:30 PM

Change #1049206 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in CreateItemRouteHandler

https://gerrit.wikimedia.org/r/1049206

gerritbot added a comment.Jun 24 2024, 3:42 PM

Change #1048887 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in AddItemAliasesInLanguageRouteHandler

https://gerrit.wikimedia.org/r/1048887

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Jun 24 2024, 5:00 PM
gerritbot added a comment.Jun 24 2024, 5:44 PM

Change #1049247 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in PatchItemAliasesRouteHandler

https://gerrit.wikimedia.org/r/1049247

gerritbot added a comment.Jun 25 2024, 8:53 AM

Change #1049468 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in PatchItemDescriptionsRouteHandler

https://gerrit.wikimedia.org/r/1049468

Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 23); removed Wikibase Product Platform Team WPP (Sprint 22).Jun 25 2024, 10:06 AM
Ifrahkhanyaree_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 23) board.
gerritbot added a comment.Jun 25 2024, 10:44 AM

Change #1049514 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in PatchItemLabelsRouteHandler

https://gerrit.wikimedia.org/r/1049514

gerritbot added a comment.Jun 25 2024, 3:07 PM

Change #1049581 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator

https://gerrit.wikimedia.org/r/1049581

gerritbot added a comment.Jun 25 2024, 3:26 PM

Change #1049100 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator

https://gerrit.wikimedia.org/r/1049100

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.12; 2024-07-02); removed MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Jun 25 2024, 4:00 PM
gerritbot added a comment.Jun 25 2024, 4:50 PM

Change #1049514 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in PatchItemLabelsRouteHandler

https://gerrit.wikimedia.org/r/1049514

gerritbot added a comment.Jun 25 2024, 7:09 PM

Change #1049206 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in CreateItemRouteHandler

https://gerrit.wikimedia.org/r/1049206

gerritbot added a comment.Jun 25 2024, 8:12 PM

Change #1049635 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator

https://gerrit.wikimedia.org/r/1049635

gerritbot added a comment.Jun 26 2024, 7:31 AM

Change #1049247 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in PatchItemAliasesRouteHandler

https://gerrit.wikimedia.org/r/1049247

gerritbot added a comment.Jun 26 2024, 7:39 AM

Change #1049820 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator

https://gerrit.wikimedia.org/r/1049820

gerritbot added a comment.Jun 26 2024, 8:02 AM

Change #1049468 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in PatchItemDescriptionsRouteHandler

https://gerrit.wikimedia.org/r/1049468

Jakob_WMDE updated the task description. (Show Details)Jun 26 2024, 1:17 PM
gerritbot added a comment.Jun 26 2024, 1:26 PM

Change #1049935 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Remove use of JsonBodyValidator in RemoveItemStatementRouteHandler

https://gerrit.wikimedia.org/r/1049935

Jakob_WMDE updated the task description. (Show Details)Jun 26 2024, 1:27 PM
Jakob_WMDE updated the task description. (Show Details)Jun 26 2024, 3:08 PM
gerritbot added a comment.Jun 27 2024, 9:11 AM

Change #1050268 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Refactor AddItemStatementRouteHandler validation

https://gerrit.wikimedia.org/r/1050268

gerritbot added a comment.Jun 27 2024, 11:48 AM

Change #1049935 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove use of JsonBodyValidator

https://gerrit.wikimedia.org/r/1049935

gerritbot added a comment.Jun 27 2024, 1:08 PM

Change #1050360 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Refactor edit route handlers validation

https://gerrit.wikimedia.org/r/1050360

gerritbot added a comment.Jun 27 2024, 1:09 PM

Change #1049581 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator

https://gerrit.wikimedia.org/r/1049581

gerritbot added a comment.Jun 27 2024, 1:18 PM

Change #1050268 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Refactor AddItemStatementRouteHandler validation

https://gerrit.wikimedia.org/r/1050268

gerritbot added a comment.Jun 27 2024, 1:39 PM

Change #1050364 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Refactor PATCH route handlers validation

https://gerrit.wikimedia.org/r/1050364

gerritbot added a comment.Jun 27 2024, 3:35 PM

Change #1050405 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/extensions/Wikibase@master] REST: Refactor AddPropertyStatement and AddPropertyAliasesInLanguage route handlers validation

https://gerrit.wikimedia.org/r/1050405

gerritbot added a comment.Jun 27 2024, 3:59 PM

Change #1050411 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in PatchItemRouteHandler

https://gerrit.wikimedia.org/r/1050411

gerritbot added a comment.Jun 27 2024, 4:50 PM

Change #1050425 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in sitelinks edit route handlers

https://gerrit.wikimedia.org/r/1050425

gerritbot added a comment.Jun 27 2024, 8:06 PM

Change #1050456 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator

https://gerrit.wikimedia.org/r/1050456

gerritbot added a comment.Jun 28 2024, 11:17 AM

Change #1050586 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator

https://gerrit.wikimedia.org/r/1050586

gerritbot added a comment.Jun 28 2024, 11:23 AM

Change #1050405 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Refactor AddPropertyStatement and AddPropertyAliasesInLanguage route handlers validation

https://gerrit.wikimedia.org/r/1050405

gerritbot added a comment.Jun 28 2024, 12:22 PM

Change #1050360 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Refactor edit route handlers validation

https://gerrit.wikimedia.org/r/1050360

gerritbot added a comment.Jun 28 2024, 12:47 PM

Change #1049635 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator

https://gerrit.wikimedia.org/r/1049635

gerritbot added a comment.Jun 28 2024, 12:47 PM

Change #1050364 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Refactor PATCH route handlers validation

https://gerrit.wikimedia.org/r/1050364

gerritbot added a comment.Jun 28 2024, 12:47 PM

Change #1050425 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in sitelinks edit route handlers

https://gerrit.wikimedia.org/r/1050425

gerritbot added a comment.Jun 28 2024, 12:47 PM

Change #1050411 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator in PatchItemRouteHandler

https://gerrit.wikimedia.org/r/1050411

gerritbot added a comment.Jun 28 2024, 1:17 PM

Change #1050586 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator

https://gerrit.wikimedia.org/r/1050586

gerritbot added a comment.Jun 28 2024, 1:45 PM

Change #1050613 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Remove use of JsonBodyValidator in SetItemLabelRouteHandler

https://gerrit.wikimedia.org/r/1050613

gerritbot added a comment.Jun 28 2024, 1:58 PM

Change #1050616 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Remove use of JsonBodyValidator in SetPropertyLabelRouteHandler

https://gerrit.wikimedia.org/r/1050616

gerritbot added a comment.Jun 28 2024, 2:30 PM

Change #1050623 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator

https://gerrit.wikimedia.org/r/1050623

gerritbot added a comment.Jun 28 2024, 3:00 PM

Change #1050616 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove use of JsonBodyValidator in SetPropertyLabelRouteHandler

https://gerrit.wikimedia.org/r/1050616

gerritbot added a comment.Jun 28 2024, 3:01 PM

Change #1050613 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove use of JsonBodyValidator in SetItemLabelRouteHandler

https://gerrit.wikimedia.org/r/1050613

gerritbot added a comment.Jun 28 2024, 3:41 PM

Change #1050456 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator

https://gerrit.wikimedia.org/r/1050456

gerritbot added a comment.Jun 28 2024, 3:42 PM

Change #1050623 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator

https://gerrit.wikimedia.org/r/1050623

Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 23) board.Jul 1 2024, 11:37 AM
gerritbot added a comment.Jul 1 2024, 2:05 PM

Change #1049820 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove usage of JsonBodyValidator

https://gerrit.wikimedia.org/r/1049820

Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 23) board.Jul 1 2024, 2:06 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 1 2024, 2:30 PM
Ollie.Shotton_WMDE closed this task as Resolved.Jul 9 2024, 9:53 AM
Ollie.Shotton_WMDE claimed this task.
daniel added a comment.Jul 9 2024, 5:11 PM

Thank you!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits