[go: nahoru, domu]

Page MenuHomePhabricator

Remove usage of JsonBodyValidator from WikimediaCampaignEvents
Closed, ResolvedPublic

Description

AC

  • REST handlers use the new validation mechanism (based on get(Body)ParamSettings) to validate the request body (see T361995).

QA notes

The following endpoint should continue to work normally:

  • Delete grant ID
  • Update grant ID

I.e., no new failures, and parameters are still validated as expected (with particular attention to non-scalar parameters, things such as arrays, usernames, page titles). There is no need to test the actual actions performed by these handlers, or more generally the success states.

Event Timeline

Change #1034110 had a related patch set uploaded (by Daimona Eaytoy; author: WQuarshie):

[mediawiki/extensions/WikimediaCampaignEvents@master] Use new body validation in the handlers

https://gerrit.wikimedia.org/r/1034110

Change #1034110 had a related patch set uploaded (by Daimona Eaytoy; author: WQuarshie):

[mediawiki/extensions/WikimediaCampaignEvents@master] Use new body validation in the handlers

https://gerrit.wikimedia.org/r/1034110

Change #1034110 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCampaignEvents@master] Use new body validation in the handlers

https://gerrit.wikimedia.org/r/1034110

vaughnwalters subscribed.

The following endpoints are working normally:

✅ Delete grant ID
✅ Update grant ID

Marking this as done / resolved.