[go: nahoru, domu]

Page MenuHomePhabricator

UploadWizard - Describe step: message "Caption/Description is required" should appear only upon submitting
Closed, ResolvedPublic

Description

Two issues descriptions below are based on these two comments: (1) the case with the Back button and (2) the case with unchecking the "Same as caption" checkbox

DONE (1) the case with the Back button
Steps:

  1. A user is on Describe step in Special:UploadWizard
  2. A user doesn't see any warning about filling Caption/Description - CORRECT behavior
  3. A user clicks on the Back button to return to the previous step
  4. Then, a user clicks again the Next button to get to the Describe step
  5. Both "Caption/Description is required" messages will be displayed.

Expected behavior: "Caption/Description is required" messages should not be displayed since a user hasn't yet attempted to publish a file.

commons_back button.gif (899×1 px, 1 MB)

DONE (2) the case with unchecking the "Same as caption" checkbox - "Description is required" message
Steps:

  1. A user is on Describe step in Special:UploadWizard
  2. A user doesn't see a warning about filling Caption/Description - CORRECT behavior
  3. A user unchecks the "Same as caption" checkbox - "Description is required" message appears

Expected behavior: "Description is required" message should not be displayed since a user hasn't yet attempted to publish a file.

commons_uncheck button.gif (899×1 px, 124 KB)

DONE (3) the case with unchecking the "Same as caption" checkbox and then checking it again - "Caption is required" message**
from @Sneha comment- https://phabricator.wikimedia.org/T366266#9850120

  1. A user is on Describe step in Special:UploadWizard
  2. A user doesn't see a warning about filling Caption/Description - CORRECT behavior
  3. A user unchecks the "Same as caption" checkbox ** - "Description is required" message appears (the case from the previous scenario)
  4. A user checks the "Same as caption" checkbox ** again - "Caption is required" message appears

Expected behavior: "Caption is required" message should not be displayed since a user hasn't yet attempted to publish a file.

Screen Shot 2024-05-31 at 12.10.36 PM.png (1×2 px, 621 KB)

(click on the animated gif below):
caption_required.gif (873×1 px, 126 KB)

Event Timeline

Change #1051758 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] Improve error handling

https://gerrit.wikimedia.org/r/1051758

Change #1051758 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Improve error handling

https://gerrit.wikimedia.org/r/1051758

Checked all three scenarios on commons beta - work as expected.

Etonkovidova updated the task description. (Show Details)