[go: nahoru, domu]

Page MenuHomePhabricator

Use Codex color tokens instead of Growth custom variables
Open, Needs TriagePublic

Description

In T357699 a low effort solution is been added to make the newcomers homepage better behave with Dark mode enable, however it introduces color contrast accessibility issues and also "degradates" some interfaces.

All Codex background colors can be inverted so the update should help on the adoption of Dark mode for Growth features

Acceptance criteria

  • All background colors use a Codex token
  • If there's no appropriate color in the Codex palette, create a request to add it or use a CSS color value that can be inverted

Known issues

Topics selector dialog
Screenshot 2024-06-19 at 17.29.57.png (1×1 px, 178 KB)
beta (June 28/2024
Screen Shot 2024-06-28 at 4.43.08 PM.png (1×810 px, 202 KB)
User impact skeleton loader
Screenshot 2024-06-19 at 17.31.45.png (1×796 px, 48 KB)
Add link task onboarding{F55529858}
Help panel{F55529857}

Event Timeline

Change #1047550 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Use Codex background colors

https://gerrit.wikimedia.org/r/1047550

Tagging this with the web team sprint board as well just so we can discuss next steps and timeline.

Change #1047550 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@master] Use Codex background colors

Reason:

Should be resolved in I33708d115955701f37394e7d0778627b2d442174

https://gerrit.wikimedia.org/r/1047550

@Sgs - two images in the task description - for Add link task onboarding and for Help panel are marked as Restricted and are not displayed.

I've added the screenshot for the first case - Topics selector dialog - seems like the issue was fixed.

Also I've added two more places where the background color is too light for the dark mode. You may remove them, if those cases are not relevant to the scope of the task.

intro tourguided tourHelp panel guided tourAdd link
Screen Shot 2024-06-28 at 4.45.18 PM.png (1×1 px, 184 KB)
Screen Shot 2024-06-28 at 4.45.45 PM.png (1×1 px, 192 KB)
Screen Shot 2024-06-28 at 4.46.45 PM.png (1×1 px, 266 KB)
Screen Shot 2024-06-28 at 4.46.59 PM.png (1×1 px, 211 KB)
Screen Shot 2024-06-28 at 4.46.53 PM.png (1×1 px, 231 KB)
Screen Shot 2024-06-28 at 3.10.00 PM.png (1×840 px, 157 KB)
Screen Shot 2024-06-28 at 3.09.50 PM.png (1×856 px, 291 KB)
Michael subscribed.

I'm not sure if anything here still needs doing? We've seem to have fixed the immediate issue, but should we still look into transitioning away from growth-specific tokens to more generic ones?

I'm adding the Technical-Debt tag here because it mainly seems like a refactoring that we may or may not want to do.

I'm not sure if anything here still needs doing? We've seem to have fixed the immediate issue, but should we still look into transitioning away from growth-specific tokens to more generic ones?

I'm adding the Technical-Debt tag here because it mainly seems like a refactoring that we may or may not want to do.

The guided/intro tours an the issue with Add link and Help panel should still in this task? I re-checked those cases - the screenshots in my comment present the current state of the dark mode for Growth features.