Maniphest T369031

🚫 Replace `invalid-patch` errors with generic `invalid-value` error
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ollie.Shotton_WMDE
	Jul 2 2024, 12:35 PM

Tags

Referenced Files

None

Subscribers

Ollie.Shotton_WMDE

Description

The new error should follow this format:

"code": "invalid-value",
"message": "Invalid value at '{json-pointer}'",
"context": { 
  "path": "{json-pointer}"
}

Note: remember to update the OAS as well.

Details

	Subject	Repo	Branch	Lines +/-
	REST: Replace invalid-patch error with invalid-value	mediawiki/extensions/Wikibase	master	+7 -46

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ifrahkhanyaree_WMDE	T366181 🚫 [Generalised error] invalid-value in request body
		Resolved		Jakob_WMDE	T369031 🚫 Replace `invalid-patch` errors with generic `invalid-value` error

Event Timeline

Ollie.Shotton_WMDE created this task.Jul 2 2024, 12:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 2 2024, 12:35 PM

Muhammad_Yasser_Jazirahly_WMDE moved this task from Sprint 23 to Sprint 24 on the Wikibase Product Platform Team WPP board.Jul 9 2024, 9:50 AM

Muhammad_Yasser_Jazirahly_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 24); removed Wikibase Product Platform Team WPP (Sprint 23).

Jakob_WMDE claimed this task.Jul 9 2024, 10:40 AM

Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 24) board.

Change #1052947 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Replace invalid-patch error with invalid-value

https://gerrit.wikimedia.org/r/1052947

gerritbot added a project: Patch-For-Review.Jul 9 2024, 10:52 AM

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 24) board.Jul 9 2024, 2:43 PM

Change #1052947 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Replace invalid-patch error with invalid-value

https://gerrit.wikimedia.org/r/1052947

Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 24) board.Jul 9 2024, 8:21 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 9 2024, 8:28 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.14; 2024-07-16).Jul 9 2024, 9:00 PM

Ifrahkhanyaree_WMDE closed this task as Resolved.Tue, Jul 23, 9:58 AM