Update `UniqueValueChecker` to query a list of endpoints
Open, Needs TriagePublic
Actions

Description

Problem
With the current work going on around testing the graph split, we investigated which of the constraint checks that are using SPARQL queries are affected.

In an investigation (see T355298 for details) we identified that if we do nothing, UniqueValueChecker will produce some false negatives.

So in order for this to run as required, we need to make UniqueValueChecker query a list of endpoints (and configure that list in production).

Acceptance Criteria

UniqueValueChecker runs as normal and produces no false negatives after the graph split

Details

	Subject	Repo	Branch	Lines +/-
	Use strict_types in recently modified files	mediawiki/extensions/WikibaseQualityConstraints	master	+108 -193
	UniqueValueChecker queries additional endpoints	mediawiki/extensions/WikibaseQualityConstraints	master	+267 -50

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T335067 Epic: Wikidata Query Service stabilization
Open	None	T337013 [Epic] Splitting the graph in WDQS
Open	AudreyPenven_WMDE	T369079 Update `UniqueValueChecker` to query a list of endpoints

Event Timeline

Arian_Bozorg created this task.Jul 2 2024, 4:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 2 2024, 4:04 PM

Maintenance_bot added a project: Wikidata.Jul 2 2024, 4:30 PM

Lydia_Pintscher added a project: Wikibase-Quality-Constraints.Jul 3 2024, 6:50 AM

Lydia_Pintscher mentioned this in T355298: Investigate the impact of the WDQS graph split on constraints checks.

Lydia_Pintscher added a parent task: T337013: [Epic] Splitting the graph in WDQS.Jul 3 2024, 6:52 AM

Arian_Bozorg moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Jul 8 2024, 4:23 PM

AudreyPenven_WMDE claimed this task.Jul 10 2024, 3:18 PM

AudreyPenven_WMDE edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team.

AudreyPenven_WMDE moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.

Arian_Bozorg updated the task description. (Show Details)Jul 15 2024, 7:26 AM

• Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jul 31 2024, 4:21 PM

• Lucas_Werkmeister_WMDE subscribed.Jul 31 2024, 4:25 PM

AudreyPenven_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Fri, Aug 9, 11:40 AM

ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Tue, Aug 13, 9:25 AM

Change #1058598 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/WikibaseQualityConstraints@master] UniqueValueChecker queries additional endpoints

https://gerrit.wikimedia.org/r/1058598

gerritbot added a project: Patch-For-Review.Tue, Aug 13, 4:41 PM

Change #1058598 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] UniqueValueChecker queries additional endpoints

https://gerrit.wikimedia.org/r/1058598

The code is updated and should hopefully work; once we actually want to use the split graph servers, we’ll still need to update the production config accordingly. (Which might not be 100% trivial, by the way – currently, wgWBQualityConstraintsSparqlEndpoint is set to http://localhost:6009/sparql, not to a public URL like https://query.wikidata.org/sparql. So I’m guessing we’ll need to configure additional envoy proxies?) But at the moment, I don’t think the servers are up and running yet, see T364363.

I’m not sure where this belongs on the board in the meantime. Maybe waiting for deployment window?

Oh, or I guess it should stay in peer review (or in development?) while the strict_types patch is still open?

Maintenance_bot removed a project: Patch-For-Review.Thu, Aug 15, 11:30 AM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.19; 2024-08-20).Thu, Aug 15, 12:00 PM

Change #1062965 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/WikibaseQualityConstraints@master] Use strict_types in recently modified files

https://gerrit.wikimedia.org/r/1062965

gerritbot added a project: Patch-For-Review.Thu, Aug 15, 3:48 PM

Change #1062965 merged by jenkins-bot: