User Details
- User Since
- Nov 5 2019, 9:43 AM (251 w, 6 d)
- Roles
- Disabled
- LDAP User
- Unknown
- MediaWiki User
- Sarai Sánchez (WMDE) [ Global Accounts ]
Jul 31 2024
Hey @Arian_Bozorg and @Charlie_WMDE. Here's a list of suggested improvements that we could evaluate applying to the Query builder in order to either fix small accessibility issues or align the layout minimally with Codex. My apologies for not being able to provide all the necessary subtasks.
The component is looking and behaving correctly on Safari v17.3, Firefox v128 and Chrome v126. Internationalization and accessibility checks done ✅
Last fixes looking good. I'm assuming that the RTL issue affecting the checkboxes, which aren't correctly aligned (see screenshot below) should be fixed as part of T371519: [QB] RTL layout is broken on staging environment.
No further changes are needed after the latest merge ✅
Design verification done! ✅ No other fixes are needed. Thank you 🙏🏻
All looking good! 💯
All texts look aligned with the design specs! Thanks for all the changes @HasanAkgun_WMDE 🙏🏻
As mentioned via DM already: Just a heads-up that some (?!) of the links included in the footer display a bigger size and line-height than those of the surrounding text. I added a note in a "Considerations" section in the Link replacement task, because I'm assuming that this will be fixed as part of that other ticket.
Jul 30 2024
This task will require design verification. Please ping Charlie Kritschmar whenever the ticket is ready to be reviewed. Thank you!
This task will require design validation. As indicated in the description, some visual changes were applied to the DateInput. We'll need to make sure that the ported component reflects the changes applied to itself and InputWithExtender (T367902).
This task will require design verification. Please ping Charlie Kritschmar whenever the ticket is ready to be reviewed. Thank you!
This task will require design verification. Please ping Charlie Kritschmar whenever the ticket is ready to be reviewed. Thank you!
This task will require design verification. Please ping Charlie Kritschmar whenever the ticket is ready to be reviewed. Thank you!
This task will require design verification. Please ping Charlie Kritschmar whenever the ticket is ready to be reviewed. Thank you!
This task will require design validation. Please ping Charlie Kritschmar whenever the ticket is ready to be reviewed. Thank you!
This task will require design validation. Please ping Charlie Kritschmar whenever the ticket is ready to be reviewed. Thank you!
Hey @HasanAkgun_WMDE! Thanks for the changes. I checked right when you shared, and found that indeed the padding between the checkbox label and the input has been corrected. I found an issue that stopped me from giving a thumbs up right away, but I now realized it's unrelated to this change: so all good! 👍🏻
Jul 29 2024
Jul 26 2024
Finding out that the side panel that contains this icon (.wbl-snl-infopanel) is in WikibaseLexeme instead of the new-lexeme-special-page repo (which only contains the form), has gotten me questioning the value of this task. Even though it'll be necessary at some point in time, it sounds like an overkill to import Codex to that environment at this point just to replace a single icon, specially when the goal is deprecating WiKit 🤔 I'd probably tend to decline this one for now. att. @Arian_Bozorg
Hey @HasanAkgun_WMDE 👋🏻 I'm sorry, but I just noticed a last misalignment between the specs and the code.
Jul 25 2024
This task will require design verification. We'll need to validate that the appearance and behavior of the component remain the same.
Jul 24 2024
This task will require design validation.
No visual changes were applied to the Quantity input component itself. Instead, we need to ensure that the ported complex component reflects the changes applied to its building blocks, as specified in every individual subtask: