| George Burgess IV | 1fdfdeba7 | 2019-10-24 18:53:29 | [diff] [blame] | 1 | --- |
| George Burgess IV | f828a224 | 2022-04-19 19:30:15 | [diff] [blame] | 2 | # TODO(crbug.com/1282228): reenable google-readability-casting once it no |
| 3 | # longer has as many false-positives. |
| George Burgess IV | 17c8e4f | 2023-05-12 19:59:23 | [diff] [blame] | 4 | # TODO(crbug.com/1406869): reenable modernize-use-default-member-init once |
| 5 | # C++20 is everywhere; it recommends using default member init for bit fields, |
| 6 | # which is C++20-only. |
| George Burgess IV | 1fdfdeba7 | 2019-10-24 18:53:29 | [diff] [blame] | 7 | Checks: '-*, |
| Tal Pressman | 89a0e82c7 | 2020-12-01 09:01:39 | [diff] [blame] | 8 | bugprone-argument-comment, |
| George Burgess IV | 9f7338f | 2022-03-17 19:28:57 | [diff] [blame] | 9 | bugprone-assert-side-effect, |
| Jan Wilken Dörrie | 9414992 | 2020-12-15 18:44:55 | [diff] [blame] | 10 | bugprone-dangling-handle, |
| 11 | bugprone-inaccurate-erase, |
| 12 | bugprone-string-constructor, |
| George Burgess IV | 37c32865 | 2020-10-01 19:40:18 | [diff] [blame] | 13 | bugprone-string-integer-assignment, |
| Daniel Cheng | 387e323 | 2022-11-25 19:43:56 | [diff] [blame] | 14 | bugprone-undefined-memory-manipulation, |
| George Burgess IV | 37c32865 | 2020-10-01 19:40:18 | [diff] [blame] | 15 | bugprone-unused-raii, |
| Maksim Ivanov | d8f65ed | 2020-08-29 03:28:21 | [diff] [blame] | 16 | bugprone-use-after-move, |
| George Burgess IV | 0cea06c | 2020-01-14 03:31:04 | [diff] [blame] | 17 | google-build-explicit-make-pair, |
| 18 | google-explicit-constructor, |
| Ryan Beltran | d4f38b67 | 2023-01-18 23:00:53 | [diff] [blame] | 19 | misc-misleading-identifier, |
| 20 | misc-homoglyph, |
| George Burgess IV | d4c5e82a | 2020-05-19 19:24:00 | [diff] [blame] | 21 | modernize-avoid-bind, |
| Avi Drissman | efca412 | 2022-01-05 23:59:36 | [diff] [blame] | 22 | modernize-concat-nested-namespaces, |
| George Burgess IV | 0cea06c | 2020-01-14 03:31:04 | [diff] [blame] | 23 | modernize-loop-convert, |
| 24 | modernize-make-shared, |
| George Burgess IV | d4c5e82a | 2020-05-19 19:24:00 | [diff] [blame] | 25 | modernize-make-unique, |
| George Burgess IV | 1fdfdeba7 | 2019-10-24 18:53:29 | [diff] [blame] | 26 | modernize-redundant-void-arg, |
| 27 | modernize-replace-random-shuffle, |
| 28 | modernize-shrink-to-fit, |
| 29 | modernize-use-bool-literals, |
| George Burgess IV | d4c5e82a | 2020-05-19 19:24:00 | [diff] [blame] | 30 | modernize-use-emplace, |
| George Burgess IV | 1fdfdeba7 | 2019-10-24 18:53:29 | [diff] [blame] | 31 | modernize-use-equals-default, |
| 32 | modernize-use-equals-delete, |
| George Burgess IV | d4c5e82a | 2020-05-19 19:24:00 | [diff] [blame] | 33 | modernize-use-noexcept, |
| George Burgess IV | 1fdfdeba7 | 2019-10-24 18:53:29 | [diff] [blame] | 34 | modernize-use-nullptr, |
| 35 | modernize-use-override, |
| George Burgess IV | 0cea06c | 2020-01-14 03:31:04 | [diff] [blame] | 36 | modernize-use-transparent-functors, |
| 37 | readability-redundant-member-init' |
| George Burgess IV | d4c5e82a | 2020-05-19 19:24:00 | [diff] [blame] | 38 | CheckOptions: |
| George Burgess IV | 9f7338f | 2022-03-17 19:28:57 | [diff] [blame] | 39 | - key: bugprone-assert-side-effect.AssertMacros |
| 40 | value: assert,DCHECK |
| Jan Wilken Dörrie | 9414992 | 2020-12-15 18:44:55 | [diff] [blame] | 41 | - key: bugprone-dangling-handle.HandleClasses |
| Peter Boström | 25a5358 | 2021-08-31 04:28:35 | [diff] [blame] | 42 | value: ::std::basic_string_view;::std::span;::absl::string_view;::base::BasicStringPiece;::base::span |
| Jan Wilken Dörrie | 9414992 | 2020-12-15 18:44:55 | [diff] [blame] | 43 | - key: bugprone-string-constructor.StringNames |
| George Burgess IV | 4f18f3f | 2022-07-05 14:24:57 | [diff] [blame] | 44 | value: ::std::basic_string;::std::basic_string_view;::base::BasicStringPiece;::absl::string_view |
| Peter Kasting | 0dc3348 | 2020-10-19 01:48:29 | [diff] [blame] | 45 | - key: modernize-use-default-member-init.UseAssignment |
| 46 | value: 1 |
| George Burgess IV | a01425e4 | 2022-07-14 02:00:58 | [diff] [blame] | 47 | # crbug.com/1342136, crbug.com/1343915: At times, this check makes |
| 48 | # suggestions that break builds. Safe mode allows us to sidestep that. |
| 49 | - key: modernize-use-transparent-functors.SafeMode |
| 50 | value: 1 |
| George Burgess IV | d4c5e82a | 2020-05-19 19:24:00 | [diff] [blame] | 51 | # This relaxes modernize-use-emplace in some cases; we might want to make it |
| 52 | # more aggressive in the future. See discussion on |
| 53 | # https://groups.google.com/a/chromium.org/g/cxx/c/noMMTNYiM0w . |
| 54 | - key: modernize-use-emplace.IgnoreImplicitConstructors |
| 55 | value: 1 |
| George Burgess IV | 8899257 | 2023-03-02 19:25:30 | [diff] [blame] | 56 | # crbug.com/1420969, crbug.com/1421042: Tricium's `show fix` button isn't |
| 57 | # working, which leads to devs thinking that clang-tidy is suggesting C++20 |
| 58 | # constructs in some cases. Until fixes can be surfaced to show that |
| 59 | # `base::Reversed` is encouraged, just turn reverse ranges off entirely. |
| 60 | # TODO(crbug.com/1404958): alternatively, remove these once C++20 is |
| 61 | # everywhere. |
| 62 | - key: modernize-loop-convert.UseCxx20ReverseRanges |
| 63 | value: false |
| George Burgess IV | 1fdfdeba7 | 2019-10-24 18:53:29 | [diff] [blame] | 64 | ... |