core: refactor check for clearing cache (#9896)

GoogleChrome · Oct 30, 2019 · 6e5fc87 · 6e5fc87
1 parent f0d7ceb
commit 6e5fc87
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/lighthouse-core/gather/gather-runner.js b/lighthouse-core/gather/gather-runner.js
@@ -597,11 +597,12 @@ class GatherRunner {
   }
 
   /**
-   * Returns whether this pass should be considered to be measuring performance.
+   * Returns whether this pass should clear the caches.
+   * Only if it is a performance run and the settings don't disable it.
    * @param {LH.Gatherer.PassContext} passContext
    * @return {boolean}
    */
-  static isPerfPass(passContext) {
+  static shouldClearCaches(passContext) {
     const {settings, passConfig} = passContext;
     return !settings.disableStorageReset && passConfig.recordTrace && passConfig.useThrottling;
   }
@@ -631,8 +632,9 @@ class GatherRunner {
     // Go to about:blank, set up, and run `beforePass()` on gatherers.
     await GatherRunner.loadBlank(driver, passConfig.blankPage);
     await GatherRunner.setupPassNetwork(passContext);
-    const isPerfPass = GatherRunner.isPerfPass(passContext);
-    if (isPerfPass) await driver.cleanBrowserCaches(); // Clear disk & memory cache if it's a perf run
+    if (GatherRunner.shouldClearCaches(passContext)) {
+      await driver.cleanBrowserCaches(); // Clear disk & memory cache if it's a perf run
+    }
     await GatherRunner.beforePass(passContext, gathererResults);
 
     // Navigate, start recording, and run `pass()` on gatherers.