core: refactor check for clearing cache #9896
Conversation
| @@ -631,8 +640,7 @@ class GatherRunner { | |||
| // Go to about:blank, set up, and run `beforePass()` on gatherers. | |||
| await GatherRunner.loadBlank(driver, passConfig.blankPage); | |||
| await GatherRunner.setupPassNetwork(passContext); | |||
| const isPerfPass = GatherRunner.isPerfPass(passContext); | |||
| if (isPerfPass) await driver.cleanBrowserCaches(); // Clear disk & memory cache if it's a perf run | |||
There was a problem hiding this comment.
Also, this comment was not useful.
There was a problem hiding this comment.
it is indeed a relic of a time when gather-runner was inscrutable and lines needed to be explained, but a reminder that it's intended to be disk and memory cache seems somewhat useful to me :)
honestly though I'm not sure why this isn't in setupPassNetwork since it's exactly supposed to set the network state
There was a problem hiding this comment.
Clear disk & memory cache if it's a perf run says three things:
- clear disk cache
- clear memory cache
- do these things only if perf run
all of which is readily apparent, either via the short jsdocs or the names of these methods.
this is getting nitty so I just put it back. Just doing the rename.
There was a problem hiding this comment.
fwiw I wasn't trying to argue that it must stay, just wanted to support why it existed and that it's not 100% devoid of value :)
but it's w/e
There was a problem hiding this comment.
isPerfPass (isPerfRun, originally: #2156) was just trying to name a heuristic for "this is a pass that's measuring performance so needs the cache cleared". It's not used anywhere else, so an extra call hop doesn't seem beneficial.
I can see how the name isn't super self explanatory (the comments point to there being thought behind it, though), so we could maybe just rename?
Didn't seem that
settings.disableStorageResetmade sense in a function calledisPerfPass, so here's a trivial refactor.