misc: add git3po scripts #10231
misc: add git3po scripts #10231
Conversation
There was a problem hiding this comment.
will npm install also upgrade to the latest version? if so, lgtm
@patrickhulce noticing some limitation wrt how startAt works. Ideally, for this use case, we'd want to not define a startAt, and have git3po write to memory somewhere (for each config) the last updated ts for the last issue it handled. Previously, @paulirish was updating startAt periodically so that the issue lookup didn't take too long. Would be nice if git3po could just read that from memory.
|
can you add a bash file to run these too? |
good call done. |
|
|
||
| npm install -g git3po | ||
|
|
||
| find git3po-rules/*.yaml -exec git3po -c {} \; |
There was a problem hiding this comment.
we can now remove startAt from all the configs and do
--start-at=`date "+%s" -d "1 hour ago"`
although the autolock one should be special-cased to 1 month ago
There was a problem hiding this comment.
k we do this in a followup.
There was a problem hiding this comment.
does that sound right @connorjclark @patrickhulce ?
Might want to use a different clone that's always pristine and fetches latest master, but ya SGTM 👍
will npm install also upgrade to the latest version? if so, lgtm
ya it should
Ideally, for this use case, we'd want to not define a startAt, and have git3po write to memory somewhere (for each config) the last updated ts for the last issue it handled. Previously, @paulirish was updating startAt periodically so that the issue lookup didn't take too long. Would be nice if git3po could just read that from memory.
Yeah I think I even had a branch of something like this a long time ago circa 2017 and paul wanted something better too (patrickhulce/git3po#5) I think we might just want an option to rewrite the latest issue timestamp back to the yaml file as startAt? otherwise it's kinda weird how we juggle what key we use for which file and whatnot
|
writing back to yaml seems fine I guess. but a |
| $lt: 2 | ||
| actions: | ||
| - type: add_comment | ||
| body: 'Howdy chief! Appreciate you filing this bug. :clap: |
There was a problem hiding this comment.
| body: 'Howdy chief! Appreciate you filing this bug. :clap: | |
| body: 'Howdy! Appreciate you filing this bug. :clap: |
I think we should remove "chief" from all of these.
| @@ -0,0 +1,16 @@ | |||
| repo: GoogleChrome/lighthouse | |||
| @@ -0,0 +1,21 @@ | |||
| repo: GoogleChrome/lighthouse | |||
|
repo: GoogleChrome/lighthouse
filters:
- type: issue
criteria:
state: open
labels:
$and:
- $includes: needs-priority
- $or:
- $includes: P0
- $includes: P1
- $includes: P1.5
- $includes: P2
- $includes: P3
actions:
- type: remove_label
label: needs-priority
|
|
i reverted your additions. lets add them back once merged. that way we can verify this whole new setup works off the latest stuff. |
|
ok it's set up on my side. 👍 cronjob runs every 5 minutes. it updates a checkout of lighthouse to master and runs |
fixes #10192
old approach..
i have many lines of this in a every-five-minutes.sh that's run via cron:
new approach after this lands..
replace those lines with this:
does that sound right @connorjclark @patrickhulce ?