[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: add git3po scripts #10231

Merged
merged 8 commits into from
Jan 23, 2020
Merged

misc: add git3po scripts #10231

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dd84ce4
misc: add git3po scripts
paulirish Jan 15, 2020
1d5e806
add script to run git3po
paulirish Jan 15, 2020
124d279
they fixed absolute paths. but we still want a reliable cwd
paulirish Jan 15, 2020
3c67c56
auto-lock
connorjclark Jan 16, 2020
f226b4d
more
connorjclark Jan 16, 2020
68c2ad5
Revert "more"
paulirish Jan 23, 2020
0582e98
Revert "auto-lock"
paulirish Jan 23, 2020
7d675ba
no more chief
paulirish Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
misc: add git3po scripts
  • Loading branch information
@paulirish
paulirish committed Jan 15, 2020
commit dd84ce420cf8269198fe8c430e4f44d967aad567
25 changes: 25 additions & 0 deletions lighthouse-core/scripts/git3po-rules/cannot-attach-to-this-target.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
repo: GoogleChrome/lighthouse
startAt: '2020-01-12T16:00:00Z'
filters:
- type: issue
criteria:
text:
$or:
- $match: 'Extension Error: Cannot attach to this target'
state: open
- type: comments
length:
$lt: 2
actions:
- type: add_comment
body: 'Howdy chief! Appreciate you filing this bug. :clap:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
body: 'Howdy chief! Appreciate you filing this bug. :clap:
body: 'Howdy! Appreciate you filing this bug. :clap:

I think we should remove "chief" from all of these.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i <3 "chief"



We think this is the same root issue as #6990. So, **we''ll automatically
mark this as a duplicate**. Thanks!

:robot: Beep beep boop.
'
- type: add_label
label: duplicate
- type: close
33 changes: 33 additions & 0 deletions lighthouse-core/scripts/git3po-rules/failed-document-request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
repo: GoogleChrome/lighthouse
startAt: '2020-01-12T16:00:00Z'
filters:
- type: issue
criteria:
text:
$or:
- $match: 'Unable to load page:'
- $match: 'Unable to load the page:'
- $match: "FAILED_DOCUMENT_REQUEST"
- $match: "ERRORED_DOCUMENT_REQUEST"
state: open
- type: comments
length:
$lt: 2
actions:
- type: add_comment
body: 'Thanks chief! Appreciate you filing this bug. :clap:


This is a known issue, most well described in #2784. So, **we''ll automatically
close this as a duplicate**.


_However_, if you believe your bug is different than the cases described there,
please comment here with "necessarily-wide-alpaca" and I''ll reopen this bug. :robot:
Beep beep boop.

'
- type: add_label
label: duplicate
- type: close

24 changes: 24 additions & 0 deletions lighthouse-core/scripts/git3po-rules/failed-to-construct-url.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
repo: GoogleChrome/lighthouse
startAt: '2020-01-12T16:00:00Z'
filters:
- type: issue
criteria:
text:
$or:
- $match: 'Failed to construct ''URL'''
state: open
- type: comments
length:
$lt: 2
actions:
- type: add_comment
body: 'Howdy chief! Appreciate you filing this bug. :clap:

This is fixed in Chrome 74, which is coming out ~March 12th.

Marking this as a duplicate of issue #6157.
:robot: Beep beep boop.
'
- type: add_label
label: duplicate
- type: close
25 changes: 25 additions & 0 deletions lighthouse-core/scripts/git3po-rules/invalid-url.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
repo: GoogleChrome/lighthouse
startAt: '2020-01-12T16:00:00Z'
filters:
- type: issue
criteria:
text:
$or:
- $match: 'Error: INVALID_URL'
state: open
- type: comments
length:
$lt: 2
actions:
- type: add_comment
body: 'Howdy chief! Appreciate you filing this bug. :clap:


We think this is the same root issue as #6421. So, **we''ll automatically
mark this as a duplicate**. Thanks!

:robot: Beep beep boop.
'
- type: add_label
label: duplicate
- type: close
27 changes: 27 additions & 0 deletions lighthouse-core/scripts/git3po-rules/multiple-tabs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@

repo: GoogleChrome/lighthouse
startAt: '2020-01-12T16:00:00Z'
filters:
- type: text
text: 'You probably have multiple tabs open to the same origin'
- type: state
state: open
- type: comments
length: 0
actions:
- type: add_comment
body: 'Howdy chief! Appreciate you filing this bug. :clap:


This is a known issue that is best described in #3024. So, **we''ll automatically
close this as a duplicate**.


_However_, if you believe your bug is different than the cases described there,
please comment here with "necessarily-wide-alpaca" and I''ll reopen this bug. :robot:
Beep beep boop.

'
- type: add_label
label: duplicate
- type: close
28 changes: 28 additions & 0 deletions lighthouse-core/scripts/git3po-rules/no-fcp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
repo: GoogleChrome/lighthouse
startAt: '2020-01-12T16:00:00Z'
filters:
- type: issue
criteria:
text:
$or:
- $match: 'Error: NO_FCP'
state: open
- type: comments
length:
$lt: 2
actions:
- type: add_comment
body: 'Howdy chief! Appreciate you filing this bug. :clap:


This page seems to take too long to paint content, and Lighthouse gives up on waiting.
If you need to change this behavior, you can run Lighthouse from the command line with
a custom config modifying maxWaitForFcp.

Marking at as dupe of #7415. Thanks!

:robot: Beep beep boop.
'
- type: add_label
label: duplicate
- type: close
25 changes: 25 additions & 0 deletions lighthouse-core/scripts/git3po-rules/no-tabid-set-for-sendcommand.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
repo: GoogleChrome/lighthouse
startAt: '2020-01-12T16:00:00Z'
filters:
- type: issue
criteria:
text:
$or:
- $match: 'No tabId set for sendCommand'
state: open
- type: comments
length:
$lt: 2
actions:
- type: add_comment
body: 'Howdy chief! Appreciate you filing this bug. :clap:


We think this is the same root issue as #5595. So, **we''ll automatically
mark this as a duplicate**. Thanks!

:robot: Beep beep boop.
'
- type: add_label
label: duplicate
- type: close
23 changes: 23 additions & 0 deletions lighthouse-core/scripts/git3po-rules/page-hung.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
repo: GoogleChrome/lighthouse
startAt: '2020-01-12T16:00:00Z'
filters:
- type: issue
criteria:
text:
$or:
- $match: 'PAGE_HUNG'
state: open
- type: comments
length:
$lt: 2
actions:
- type: add_comment
body: 'Howdy chief! Appreciate you filing this bug. :clap:

This error means that the page stopped responding. The solution here is to re-run. If the error repeats, the page or your machine creates infinite loops and needs to be fixed.

:robot: Beep beep boop.
'
- type: add_label
label: duplicate
- type: close
28 changes: 28 additions & 0 deletions lighthouse-core/scripts/git3po-rules/parsing-problem.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@

repo: GoogleChrome/lighthouse
startAt: '2020-01-12T16:00:00Z'
filters:
- type: issue
criteria:
text:
$or:
- $match: 'Parsing problem'
- $match: "PARSING_PROBLEM"
state: open
- type: comments
length:
$lt: 2
actions:
- type: add_comment
body: 'Howdy chief! Appreciate you filing this bug. :clap:


We think this is the same root issue as #3306. So, **we''ll automatically
mark this as a duplicate**. Thanks!

:robot: Beep beep boop.
'
- type: add_label
label: duplicate
- type: close

25 changes: 25 additions & 0 deletions lighthouse-core/scripts/git3po-rules/protocol-timeout.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
repo: GoogleChrome/lighthouse
startAt: '2020-01-12T16:00:00Z'
filters:
- type: issue
criteria:
text:
$or:
- $match: 'Error: PROTOCOL_TIMEOUT'
state: open
- type: comments
length:
$lt: 2
actions:
- type: add_comment
body: 'Howdy chief! Appreciate you filing this bug. :clap:


We think this is the same root issue as #6512. So, **we''ll automatically
mark this as a duplicate**. Thanks!

:robot: Beep beep boop.
'
- type: add_label
label: duplicate
- type: close
31 changes: 31 additions & 0 deletions lighthouse-core/scripts/git3po-rules/read-failed.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@

repo: GoogleChrome/lighthouse
startAt: '2020-01-12T16:00:00Z'
filters:
- type: issue
criteria:
text:
$or:
- $match: "Read failed"
- $match: "READ_FAILED"
state: open
- type: comments
length:
$lt: 2
actions:
- type: add_comment
body: 'Howdy chief! Appreciate you filing this bug. :clap:


We think this is mighty similar to #2174. So, **we''ll automatically
close this as a duplicate**.


_However_, if you believe this is a mistake,
please comment here with "necessarily-wide-alpaca" and I''ll reopen this bug. :robot:
Beep beep boop.

'
- type: add_label
label: duplicate
- type: close
25 changes: 25 additions & 0 deletions lighthouse-core/scripts/git3po-rules/resolve-current-tab.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
repo: GoogleChrome/lighthouse
startAt: '2020-01-12T16:00:00Z'
filters:
- type: issue
criteria:
text:
$or:
- $match: 'resolve current tab. Check your URL'
state: open
- type: comments
length:
$lt: 2
actions:
- type: add_comment
body: 'Howdy chief! Appreciate you filing this bug. :clap:


We think this is the same root issue as #5668. So, **we''ll automatically
mark this as a duplicate**. Thanks!

:robot: Beep beep boop.
'
- type: add_label
label: duplicate
- type: close
26 changes: 26 additions & 0 deletions lighthouse-core/scripts/git3po-rules/tracing-start-wasnt-found.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
repo: GoogleChrome/lighthouse
startAt: '2020-01-12T16:00:00Z'
filters:
- type: issue
criteria:
text:
$and:
- $match: 'Error: Protocol error'
- $match: '''Tracing.start'' wasn''t found'
state: open
- type: comments
length:
$lt: 2
actions:
- type: add_comment
body: 'Howdy chief! Appreciate you filing this bug. :clap:


We think this is the same root issue as #7246. So, **we''ll automatically
mark this as a duplicate**. Thanks!

:robot: Beep beep boop.
'
- type: add_label
label: duplicate
- type: close
27 changes: 27 additions & 0 deletions lighthouse-core/scripts/git3po-rules/tracing.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@

repo: GoogleChrome/lighthouse
startAt: '2020-01-12T16:00:00Z'
filters:
- type: issue
criteria:
text:
$or:
- $match: "Tracing is already started"
- $match: "TRACING_ALREADY_STARTED"
state: open
- type: comments
length:
$lt: 2
actions:
- type: add_comment
body: 'Howdy chief! Appreciate you filing this bug. :clap:


We think this is the same root issue as #1091. So, **we''ll automatically
mark this as a duplicate**. Thanks!

:robot: Beep beep boop.
'
- type: add_label
label: duplicate
- type: close
Loading