[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: introduce script to swap in new locale to LHR #8755

Merged
merged 17 commits into from
Jun 25, 2019
Merged

i18n: introduce script to swap in new locale to LHR #8755

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a8ff2a0
i18n: introduce script to swap in new locale to LHR
paulirish Apr 19, 2019
81b0dc4
rename
paulirish Apr 22, 2019
e12f714
add start of a test.
paulirish Apr 24, 2019
30bb475
revert now build changes.
paulirish Apr 30, 2019
059bc0f
feedback
paulirish May 2, 2019
54c4833
rename to fallbackMessage
paulirish May 2, 2019
bdd29b4
fix espanol string
paulirish May 3, 2019
fdf96e8
Merge branch 'master' into swaplocale
paulirish May 3, 2019
5255aee
Update lighthouse-core/lib/i18n/swap-locale.js
paulirish May 28, 2019
627f7be
Update lighthouse-core/lib/i18n/swap-locale.js
paulirish May 28, 2019
3531318
feedback
paulirish May 28, 2019
5654af1
console time
paulirish May 28, 2019
a225504
Merge branch 'master' into swaplocale
paulirish May 28, 2019
853bfd2
drop casts
paulirish May 28, 2019
e3f2d3f
return warnings. feedback
paulirish Jun 5, 2019
5efe7eb
Merge branch 'master' into swaplocale
paulirish Jun 5, 2019
cf0d3b7
remove lherror dep
paulirish Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add start of a test.
  • Loading branch information
@paulirish
paulirish committed Apr 30, 2019
commit e12f7144ab31fe9b31ba2a7cfc27d22f2af165d8
4 changes: 4 additions & 0 deletions lighthouse-core/lib/i18n/swap-locale.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,12 @@ const i18n = require('./i18n.js');
* Replaces all strings within an LHR with ones from a different locale
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this might be worth being the place where we explain how the icuMessagePaths property is setup and meant to be used?

paulirish marked this conversation as resolved.
Show resolved Hide resolved
* @param {LH.Result} lhr
* @param {LH.Locale} requestedLocale
* @return {LH.Result}
*/
function swapLocale(lhr, requestedLocale) {
// copy LHR to avoid mutating provided LHR
paulirish marked this conversation as resolved.
Show resolved Hide resolved
lhr = JSON.parse(JSON.stringify(lhr));

const locale = i18n.lookupLocale(requestedLocale);
const {icuMessagePaths} = lhr.i18n;

Expand Down
28 changes: 28 additions & 0 deletions lighthouse-core/test/lib/i18n/swap-locale-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
/**
* @license Copyright 2018 Google Inc. All Rights Reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2019 :)

* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
*/
'use strict';

const swapLocale = require('../../../lib/i18n/swap-locale.js');

const lhr = require('../../results/sample_v2.json');

/* eslint-env jest */

describe('swap-locale', () => {

This comment was marked as resolved.

Sign in to view

it('can change golden LHR english strings into spanish', () => {
const lhrEn = /** @type {LH.Result} */ (JSON.parse(JSON.stringify(lhr)));

expect(lhrEn.audits.plugins.title).toEqual('Document avoids plugins');
expect(lhrEn.audits['dom-size'].displayValue).toEqual('31 elements');

const lhrEs = swapLocale(lhrEn, 'es');

// Basic replacement
expect(lhrEs.audits.plugins.title).toEqual('El documento no usa complementos');
// With ICU string argument values
expect(lhrEs.audits['dom-size'].displayValue).toEqual('31 nodos');
});

This comment was marked as outdated.

Sign in to view

});