[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: introduce script to swap in new locale to LHR #8755

Merged
merged 17 commits into from
Jun 25, 2019
Merged

i18n: introduce script to swap in new locale to LHR #8755

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a8ff2a0
i18n: introduce script to swap in new locale to LHR
paulirish Apr 19, 2019
81b0dc4
rename
paulirish Apr 22, 2019
e12f714
add start of a test.
paulirish Apr 24, 2019
30bb475
revert now build changes.
paulirish Apr 30, 2019
059bc0f
feedback
paulirish May 2, 2019
54c4833
rename to fallbackMessage
paulirish May 2, 2019
bdd29b4
fix espanol string
paulirish May 3, 2019
fdf96e8
Merge branch 'master' into swaplocale
paulirish May 3, 2019
5255aee
Update lighthouse-core/lib/i18n/swap-locale.js
paulirish May 28, 2019
627f7be
Update lighthouse-core/lib/i18n/swap-locale.js
paulirish May 28, 2019
3531318
feedback
paulirish May 28, 2019
5654af1
console time
paulirish May 28, 2019
a225504
Merge branch 'master' into swaplocale
paulirish May 28, 2019
853bfd2
drop casts
paulirish May 28, 2019
e3f2d3f
return warnings. feedback
paulirish Jun 5, 2019
5efe7eb
Merge branch 'master' into swaplocale
paulirish Jun 5, 2019
cf0d3b7
remove lherror dep
paulirish Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
console time
  • Loading branch information
@paulirish
paulirish committed May 28, 2019
commit 5654af17936a29dffebab65323ee21d0f869f251
7 changes: 6 additions & 1 deletion lighthouse-core/lib/i18n/swap-locale.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ function swapLocale(lhr, requestedLocale) {

const locale = i18n.lookupLocale(requestedLocale);
const {icuMessagePaths} = lhr.i18n;
const missingIcuMessageIds = /** @type {string[]} */([]);

Object.entries(icuMessagePaths).forEach(([icuMessageId, messageInstancesInLHR]) => {
for (const instance of messageInstancesInLHR) {
Expand All @@ -73,14 +74,18 @@ function swapLocale(lhr, requestedLocale) {
_set(lhr, path, formattedStr);
} catch (err) {
if (err.message === 'No ICU message string to format') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels like it will get out of date and we won't notice :)

any way you can think of to make this a little more foolproof? export the string in i18n maybe? a flag on the error? 🤷‍♂

console.error('No message found for ', {locale, icuMessageId});
missingIcuMessageIds.push(icuMessageId);
} else {
throw err;
}
}
}
});

if (missingIcuMessageIds.length) {
console.error(`No message in locale (${locale}) found for:\n`, missingIcuMessageIds);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe these get returned as warnings if we split the logging into a script?

}

lhr.i18n.rendererFormattedStrings = i18n.getRendererFormattedStrings(locale);
// Tweak the config locale
lhr.configSettings.locale = locale;
Expand Down
5 changes: 5 additions & 0 deletions lighthouse-core/test/lib/i18n/swap-locale-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ const swapLocale = require('../../../lib/i18n/swap-locale.js');
const lhr = require('../../results/sample_v2.json');

/* eslint-env jest */
beforeEach(() => {
// silence console.error spam about messages not found
// eslint-disable-next-line no-console
console.error = jest.fn();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully won't need this one :)

});

describe('swap-locale', () => {

This comment was marked as resolved.

Sign in to view

it('can change golden LHR english strings into spanish', () => {
Expand Down