[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(gather-runner): detect Chrome interstitials #9176

Merged
merged 7 commits into from
Jun 12, 2019
Merged

core(gather-runner): detect Chrome interstitials #9176

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4d258c7
core(gather-runner): detect Chrome interstitials
patrickhulce Jun 10, 2019
51b560f
better comment and tests
patrickhulce Jun 10, 2019
ebc62aa
Update lighthouse-core/test/gather/gather-runner-test.js
patrickhulce Jun 11, 2019
14e1809
fixtures
patrickhulce Jun 11, 2019
4f2bb6b
Merge branch 'interstitial_fix' of github.com:GoogleChrome/lighthouse…
patrickhulce Jun 11, 2019
adf3775
more tests and feedback
patrickhulce Jun 12, 2019
e2c7e95
Update lighthouse-core/gather/gather-runner.js
patrickhulce Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update lighthouse-core/gather/gather-runner.js
  • Loading branch information
@patrickhulce
patrickhulce committed Jun 12, 2019
commit e2c7e95c5436840d44e0f6bf43b0275896b9eaf0
2 changes: 1 addition & 1 deletion lighthouse-core/gather/gather-runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ class GatherRunner {
const pageNetworkRecords = networkRecords
.filter(record => !URL.NON_NETWORK_PROTOCOLS.includes(record.protocol) &&
!record.documentURL.startsWith('chrome-error://'));
// If at least one request didn't fail, there's no error here.
// If none of the requests failed, there's no error here.
// We don't expect that this case could ever occur, but better safe than sorry.
// Note also that in cases of redirects, the initial requests could succeed and we still end up
// on the error interstitial page.
Expand Down