[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(gather-runner): detect Chrome interstitials #9176

Merged
merged 7 commits into from
Jun 12, 2019
Merged

core(gather-runner): detect Chrome interstitials #9176

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4d258c7
core(gather-runner): detect Chrome interstitials
patrickhulce Jun 10, 2019
51b560f
better comment and tests
patrickhulce Jun 10, 2019
ebc62aa
Update lighthouse-core/test/gather/gather-runner-test.js
patrickhulce Jun 11, 2019
14e1809
fixtures
patrickhulce Jun 11, 2019
4f2bb6b
Merge branch 'interstitial_fix' of github.com:GoogleChrome/lighthouse…
patrickhulce Jun 11, 2019
adf3775
more tests and feedback
patrickhulce Jun 12, 2019
e2c7e95
Update lighthouse-core/gather/gather-runner.js
patrickhulce Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixtures
  • Loading branch information
@patrickhulce
patrickhulce committed Jun 11, 2019
commit 14e18094e79e3d7c401036a34942ebee6ca887e0
4 changes: 4 additions & 0 deletions lighthouse-core/lib/i18n/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1347,6 +1347,10 @@
"message": "The URL you have provided does not have a valid security certificate. {securityMessages}",
"description": "Error message explaining that the security certificate of the page Lighthouse observed was invalid, so the URL cannot be accessed. securityMessages will be replaced with one or more strings from the browser explaining what was insecure about the page load."
},
"lighthouse-core/lib/lh-error.js | pageLoadFailedInterstitial": {
"message": "Chrome prevented page load with an interstitial. Make sure you are testing the correct URL and that the server is properly responding to all requests.",
"description": "Error message explaining that Chrome prevented the page from loading and displayed an interstitial screen instead, so the URL cannot be accessed."
},
"lighthouse-core/lib/lh-error.js | pageLoadFailedWithDetails": {
"message": "Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Details: {errorDetails})",
"description": "Error message explaining that Lighthouse could not load the requested URL and the steps that might be taken to fix the unreliability."
Expand Down