[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables view does not show custom hover #208429

Closed
bpasero opened this issue Mar 22, 2024 · 3 comments · Fixed by #209058
Closed

Variables view does not show custom hover #208429

bpasero opened this issue Mar 22, 2024 · 3 comments · Fixed by #209058
Assignees
@roblourens @connor4312
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders
Milestone
April 2024

Comments

@bpasero
Copy link
Member
bpasero commented Mar 22, 2024

image

//cc @benibenj
@benibenj
Copy link
Contributor

You can use the setupCustomHover function on the HTMLElement to setup the hover. You will need to provide a hover delegate. If you do not require any special behaviour you can call getDefaultHoverDelegate('mouse') to get the default hover delegate.

@connor4312 connor4312 added debug Debug viewlet, configurations, breakpoints, adapter issues debt Code quality issues labels Mar 22, 2024
connor4312 added a commit that referenced this issue Mar 28, 2024
@connor4312
debug: fix variables view does not show custom hover
e29bb79 
Fixes #208429

Also adds easy access to copy expression/evaluateName since a user is
likely to do that after looking at the value (which is often incomplete
or summarized in the variables view)

![](https://memes.peet.io/img/24-03-26f2738f-6b21-4223-90ea-4e6938720582.png)

cc @amunger if you want to adopt this for notebook variables: extra
commands can be added in the hover by passing an object into `hover`.

Note: the hover is too persistent right now due to #209057
@connor4312 connor4312 mentioned this issue Mar 28, 2024
Merged
connor4312 added a commit that referenced this issue Mar 28, 2024
@connor4312
debug: fix variables view does not show custom hover (#209058)
92bf068 
* debug: fix variables view does not show custom hover

Fixes #208429

Also adds easy access to copy expression/evaluateName since a user is
likely to do that after looking at the value (which is often incomplete
or summarized in the variables view)

![](https://memes.peet.io/img/24-03-26f2738f-6b21-4223-90ea-4e6938720582.png)

cc @amunger if you want to adopt this for notebook variables: extra
commands can be added in the hover by passing an object into `hover`.

Note: the hover is too persistent right now due to #209057

* fix formatting

* use action bar instead
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Mar 28, 2024
@VSCodeTriageBot VSCodeTriageBot added this to the March 2024 milestone Mar 28, 2024
@roblourens
Copy link
Member

Should be April, right?

@roblourens roblourens modified the milestones: March 2024, April 2024 Apr 1, 2024
@connor4312
Copy link
Member

Yes, sorry

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 4, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@connor4312 connor4312

Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
April 2024
Development

Successfully merging a pull request may close this issue.

debug: fix variables view does not show custom hover microsoft/vscode
5 participants
@roblourens @bpasero @connor4312 @benibenj @VSCodeTriageBot