[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: fix variables view does not show custom hover #209058

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

connor4312
Copy link
Member

Fixes #208429

Also adds easy access to copy expression/evaluateName since a user is
likely to do that after looking at the value (which is often incomplete
or summarized in the variables view)

cc @amunger if you want to adopt this for notebook variables: extra
commands can be added in the hover by passing an object into hover.

Note: the hover is too persistent right now due to #209057

Fixes #208429

Also adds easy access to copy expression/evaluateName since a user is
likely to do that after looking at the value (which is often incomplete
or summarized in the variables view)

![](https://memes.peet.io/img/24-03-26f2738f-6b21-4223-90ea-4e6938720582.png)

cc @amunger if you want to adopt this for notebook variables: extra
commands can be added in the hover by passing an object into `hover`.

Note: the hover is too persistent right now due to #209057
@connor4312 connor4312 self-assigned this Mar 28, 2024
@connor4312 connor4312 enabled auto-merge (squash) March 28, 2024 18:59
@VSCodeTriageBot VSCodeTriageBot added this to the March 2024 milestone Mar 28, 2024
mjbvz
mjbvz previously approved these changes Mar 28, 2024
Copy link
Member
@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@connor4312 connor4312 merged commit 92bf068 into main Mar 28, 2024
6 checks passed
@connor4312 connor4312 deleted the connor4312/issue208429 branch March 28, 2024 20:46
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variables view does not show custom hover
4 participants