change directory objects to never create new versions #17109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a58238
to
3f862a8
Compare
all directory objects will always create a `null` version.
3f862a8
to
da74e0a
Compare
harshavardhana
commented
May 2, 2023
| @@ -78,8 +78,6 @@ To exclude objects under a list of prefix (glob) patterns from being versioned, | |||
| ``` | |||
| <VersioningConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/"> | |||
| <Status>Enabled</Status> | |||
| <ExcludeFolders>true</ExcludeFolders> | |||
There was a problem hiding this comment.
Removing this reference so that we can tone down this feature..
krisis
approved these changes
May 2, 2023
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
May 4, 2023
simplifies minio#17109 and extends this to deletes as well
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
May 4, 2023
simplifies minio#17109 and extends this to deletes as well, tests are added to verify the expected behavior.
8 tasks
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
May 4, 2023
simplifies minio#17109 and extends this to deletes as well, tests are added to verify the expected behavior.
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
May 4, 2023
simplifies minio#17109 and extends this to deletes as well, tests are added to verify the expected behavior.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change directory objects to never create new versions
Motivation and Context
all directory objects will always create a
nullversion.How to test this PR?
Tests added so should cover CI/CD
Types of changes
Checklist:
commit-idorPR #here)