[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow deletes on directory objects to perform permanent deletes #17132

Merged
merged 1 commit into from
May 4, 2023
Merged

allow deletes on directory objects to perform permanent deletes #17132

merged 1 commit into from
May 4, 2023

Conversation

harshavardhana
Copy link
Member

Description

allow deletes on directory objects to perform permanent deletes

Motivation and Context

simplifies #17109 and extends this to deletes as well,
tests are added to verify the expected behavior.

How to test this PR?

Tests should cover all the expected scenarios

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

poornas
poornas reviewed May 4, 2023
View reviewed changes
cmd/bucket-handlers.go Outdated Show resolved Hide resolved
@harshavardhana
allow deletes on directory objects to perform permanent deletes
9dc2c4e 
simplifies minio#17109 and extends this to deletes as well, tests
are added to verify the expected behavior.
@harshavardhana harshavardhana merged commit 1d0211d into minio:master May 4, 2023
@harshavardhana harshavardhana deleted the fix-deletes branch May 4, 2023 21:43
@djwfyi djwfyi mentioned this pull request May 5, 2023
Closed
8 tasks
@klauspost klauspost mentioned this pull request Jun 23, 2023
Closed
klauspost added a commit to klauspost/minio that referenced this pull request Jun 23, 2023
@klauspost
Remove 'null' version ID from directory object response
b665e18 
Fixes minio#17494

Regression from minio#17132
@klauspost klauspost mentioned this pull request Jun 23, 2023
Merged
2 tasks
harshavardhana pushed a commit that referenced this pull request Jun 23, 2023
@klauspost
Remove 'null' version ID from directory object response (#17495)
216069d 
Fixes #17494

Regression from #17132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poornas poornas poornas approved these changes

@krisis krisis Awaiting requested review from krisis

@vadmeste vadmeste Awaiting requested review from vadmeste

Assignees
No one assigned
Labels
performance/optimize
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshavardhana @poornas @bh4t