[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3 sync #2154

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Fix S3 sync #2154

merged 4 commits into from
Jun 14, 2024

Conversation

alishakawaguchi
Copy link
Contributor
@alishakawaguchi alishakawaguchi commented Jun 14, 2024
  • s3 path was broken because of missing runId
  • s3 sync broken when it was the only destination because of update configs for circular dependencies

@alishakawaguchi alishakawaguchi self-assigned this Jun 14, 2024
Copy link
vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 6:11pm

Copy link
codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Project coverage is 17.85%. Comparing base (f493d0e) to head (58ea758).
Report is 4 commits behind head on main.

Files Patch % Lines
.../activities/gen-benthos-configs/benthos-builder.go 28.57% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2154      +/-   ##
==========================================
+ Coverage   17.83%   17.85%   +0.02%     
==========================================
  Files         224      224              
  Lines       49488    49498      +10     
==========================================
+ Hits         8824     8839      +15     
+ Misses      39539    39536       -3     
+ Partials     1125     1123       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alishakawaguchi alishakawaguchi merged commit e7e8c74 into main Jun 14, 2024
11 checks passed
@alishakawaguchi alishakawaguchi deleted the alisha/fix-s3-sync branch June 14, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant