[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S3 sync #2154

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Fix S3 sync #2154

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d0e585
fixed aws s3 path
alishakawaguchi Jun 14, 2024
7be113e
lint
alishakawaguchi Jun 14, 2024
fc2e4d6
fix sync when only destination is s3
alishakawaguchi Jun 14, 2024
58ea758
update docs and fix test
alishakawaguchi Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fixed aws s3 path
  • Loading branch information
@alishakawaguchi
alishakawaguchi committed Jun 14, 2024
commit 5d0e5853cde5c7bd6f8cee5f78533d180034ac6d
2 changes: 1 addition & 1 deletion worker/pkg/workflows/datasync/activities/gen-benthos-configs/sync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ func (b *benthosBuilder) getAwsS3SyncBenthosOutput(
AwsS3: &neosync_benthos.AwsS3Insert{
Bucket: connection.AwsS3Config.Bucket,
MaxInFlight: 64,
Path: fmt.Sprintf("/%s", strings.Join(s3pathpieces, "/")),
Path: fmt.Sprintf("%s", strings.Join(s3pathpieces, "/")),
Batching: &neosync_benthos.Batching{
Count: 100,
Period: "5s",
Expand Down
3 changes: 2 additions & 1 deletion worker/pkg/workflows/datasync/workflow/workflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ func Workflow(wfctx workflow.Context, req *WorkflowRequest) (*WorkflowResponse,
logger.Info("scheduling GenerateBenthosConfigs for execution.")
var genbenthosactivity *genbenthosconfigs_activity.Activity
err := workflow.ExecuteActivity(ctx, genbenthosactivity.GenerateBenthosConfigs, &genbenthosconfigs_activity.GenerateBenthosConfigsRequest{
JobId: req.JobId,
JobId: req.JobId,
WorkflowId: wfinfo.WorkflowExecution.ID,
}).Get(ctx, &bcResp)
if err != nil {
return nil, err
Expand Down