[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from original #2

Merged
merged 61 commits into from
Dec 21, 2016
Merged

Update from original #2

merged 61 commits into from
Dec 21, 2016

Conversation

osaid-r
Copy link
Owner
@osaid-r osaid-r commented Dec 21, 2016

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

nijel and others added 30 commits December 13, 2016 11:51
I see no reason why this should be done, the fatal error is used
in following cases:

* Very early when there is no session (eg. missing extension)
* Invalid value for parameters
* Invalid invocation like too big request

In neither case session removal will do any good.

Signed-off-by: Michal Čihař <michal@cihar.com>
Fixed stored procedure execution.

Fixes #12813

Signed-off-by: Michal Čihař <michal@cihar.com>
We can not rely on whole stack being ready.

Fixes #12810

Signed-off-by: Michal Čihař <michal@cihar.com>
Issues #12801 and #12802

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
Currently translated at 100.0% (3222 of 3222 strings)

[CI skip]
Currently translated at 100.0% (3239 of 3239 strings)

[CI skip]
Currently translated at 100.0% (3222 of 3222 strings)

[CI skip]
Currently translated at 100.0% (3239 of 3239 strings)

[CI skip]
Currently translated at 100.0% (3222 of 3222 strings)

[CI skip]
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
This avoids additional call in the shutdown handler.

Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
Fixes #12786

Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Currently translated at 100.0% (3222 of 3222 strings)

[CI skip]
Currently translated at 99.8% (3234 of 3239 strings)

[CI skip]
Issue #12348

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel and others added 28 commits December 19, 2016 15:20
Fixes #12802

Signed-off-by: Michal Čihař <michal@cihar.com>
Do not delete session on fatal error
Fixes #12828

Signed-off-by: Michal Čihař <michal@cihar.com>
* the user set collation is now honored
* default value has been changed to utf8mb4
* it is downgraded to utf8 if server does not support it

Fixes #12826

Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
The null is there implicitely anyway.

Fixes #12829

Signed-off-by: Michal Čihař <michal@cihar.com>
Issue #12804

Signed-off-by: Michal Čihař <michal@cihar.com>
…base.

Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>
…base.

Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>
Issue #12293

Signed-off-by: Michal Čihař <michal@cihar.com>
Without calling openssl_error_string() we pollute openssl global state
and some other library might report this as failure (eg. mysqlnd driver
when connecting to SSL enabled server).

Fixes #12293

Signed-off-by: Michal Čihař <michal@cihar.com>
Issue #12293

Signed-off-by: Michal Čihař <michal@cihar.com>
This ensures we generate compatible data in both cases.

Issue #12293

Signed-off-by: Michal Čihař <michal@cihar.com>
* Added mocking of response object
* Rectified mistake of calling method once
* implemented mock properly
* replaced header with response header 

Issue #12079

Signed-off-by: Osaid osaid.nasir@gmail.com
Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>
Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>
Issue #12838, #12069

Signed-off-by: Michal Čihař <michal@cihar.com>
Issue #12838, #12069

Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
@osaid-r osaid-r merged commit a88ed64 into osaid-r:master Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants