[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom header shown twice with cookie login #12801

Closed
ibennetch opened this issue Dec 12, 2016 · 1 comment
Closed

Custom header shown twice with cookie login #12801

ibennetch opened this issue Dec 12, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@ibennetch
Copy link
Member

When using a config.header.inc.php file and auth_type cookie, the header is displayed twice on the login page

Tested with 4.6.5.2 and master.

@ibennetch ibennetch self-assigned this Dec 12, 2016
ibennetch added a commit to ibennetch/phpmyadmin that referenced this issue Dec 12, 2016
Issues phpmyadmin#12801 and phpmyadmin#12802

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
ibennetch added a commit to ibennetch/phpmyadmin that referenced this issue Dec 12, 2016
Issues phpmyadmin#12801 and phpmyadmin#12802

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
ibennetch added a commit to ibennetch/phpmyadmin that referenced this issue Dec 14, 2016
Issues phpmyadmin#12801 and phpmyadmin#12802

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
@nijel nijel added this to the 4.6.6 milestone Dec 19, 2016
@nijel
Copy link
Contributor
nijel commented Dec 19, 2016

Fixed by #12803

@nijel nijel closed this as completed Dec 19, 2016
osaid-r added a commit to osaid-r/phpmyadmin that referenced this issue Dec 21, 2016
* Do not delete session on fatal error

I see no reason why this should be done, the fatal error is used
in following cases:

* Very early when there is no session (eg. missing extension)
* Invalid value for parameters
* Invalid invocation like too big request

In neither case session removal will do any good.

Signed-off-by: Michal Čihař <michal@cihar.com>

* Do not use control link when working with stored procedures

Fixed stored procedure execution.

Fixes phpmyadmin#12813

Signed-off-by: Michal Čihař <michal@cihar.com>

* Fix early fatal errors

We can not rely on whole stack being ready.

Fixes phpmyadmin#12810

Signed-off-by: Michal Čihař <michal@cihar.com>

* Fix display of custom header and footer in certain edge cases.
Issues phpmyadmin#12801 and phpmyadmin#12802

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>

* Translated using Weblate (Dutch)

Currently translated at 100.0% (3222 of 3222 strings)

[CI skip]

* Translated using Weblate (Dutch)

Currently translated at 100.0% (3239 of 3239 strings)

[CI skip]

* Translated using Weblate (French)

Currently translated at 100.0% (3222 of 3222 strings)

[CI skip]

* Translated using Weblate (French)

Currently translated at 100.0% (3239 of 3239 strings)

[CI skip]

* Translated using Weblate (French)

Currently translated at 100.0% (3222 of 3222 strings)

[CI skip]

* MySQL allows precision to be specified for DATETIME, TIME type fields too

Fix phpmyadmin#12814

Ref : http://dev.mysql.com/doc/refman/5.7/en/fractional-seconds.html

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>

* ChangeLog for phpmyadmin#12814

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>

* Share code for cascading ajax flag

Signed-off-by: Michal Čihař <michal@cihar.com>

* Get response instance just once

Signed-off-by: Michal Čihař <michal@cihar.com>

* Register shutdown directly on singleton instance

This avoids additional call in the shutdown handler.

Signed-off-by: Michal Čihař <michal@cihar.com>

* Simplify checking for ajax request

Signed-off-by: Michal Čihař <michal@cihar.com>

* Include token in all filter requests

Fixes phpmyadmin#12786

Signed-off-by: Michal Čihař <michal@cihar.com>

* Fix documentation markup

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>

* Hints about using Composer for library dependencies

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>

* Use documentation link instead of wiki for Composer details

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>

* Uncomment mistakenly commented Selenium testing setting

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>

* Translated using Weblate (Spanish)

Currently translated at 100.0% (3222 of 3222 strings)

[CI skip]

* Translated using Weblate (Spanish)

Currently translated at 99.8% (3234 of 3239 strings)

[CI skip]

* Remove .htaccess from tests

Issue phpmyadmin#12348

Signed-off-by: Michal Čihař <michal@cihar.com>

* Add source release support

See phpmyadmin#12348

Signed-off-by: Michal Čihař <michal@cihar.com>

* Share code for rendering custom header and footer

Fixes phpmyadmin#12802

Signed-off-by: Michal Čihař <michal@cihar.com>

* Fix empty password login for http authetication

Fixes phpmyadmin#12828

Signed-off-by: Michal Čihař <michal@cihar.com>

* Honor user configured connection collation

* the user set collation is now honored
* default value has been changed to utf8mb4
* it is downgraded to utf8 if server does not support it

Fixes phpmyadmin#12826

Signed-off-by: Michal Čihař <michal@cihar.com>

* Fix HTTP auth test expectations

Signed-off-by: Michal Čihař <michal@cihar.com>

* Remove default value for js parameter

The null is there implicitely anyway.

Fixes phpmyadmin#12829

Signed-off-by: Michal Čihař <michal@cihar.com>

* Add some missing html encoding

Issue phpmyadmin#12804

Signed-off-by: Michal Čihař <michal@cihar.com>

* Feature: phpmyadmin#12069: Filtering tables on table listing of particular database.

Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>

* Feature: phpmyadmin#12069: Filtering tables on table listing of particular database.

Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>

* Determine whether to use openssl just once

Issue phpmyadmin#12293

Signed-off-by: Michal Čihař <michal@cihar.com>

* Correctly report OpenSSL errors from cookie encryption

Without calling openssl_error_string() we pollute openssl global state
and some other library might report this as failure (eg. mysqlnd driver
when connecting to SSL enabled server).

Fixes phpmyadmin#12293

Signed-off-by: Michal Čihař <michal@cihar.com>

* Use same encryption key with openssl and phpseclib

Issue phpmyadmin#12293

Signed-off-by: Michal Čihař <michal@cihar.com>

* Test both with and without phpseclib

This ensures we generate compatible data in both cases.

Issue phpmyadmin#12293

Signed-off-by: Michal Čihař <michal@cihar.com>

* Use Header class for headers manipulation

* Added mocking of response object
* Rectified mistake of calling method once
* implemented mock properly
* replaced header with response header 

Issue phpmyadmin#12079

Signed-off-by: Osaid osaid.nasir@gmail.com

* Inline javascript codes are removed. Each is used for table search

Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>

* Update db_structure.js

* Tab spaces are removed.

Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>

* Unbind event on page unload

Issue phpmyadmin#12838, phpmyadmin#12069

Signed-off-by: Michal Čihař <michal@cihar.com>

* Use existing filtering template for table filtering

Issue phpmyadmin#12838, phpmyadmin#12069

Signed-off-by: Michal Čihař <michal@cihar.com>

* Changelog for issues phpmyadmin#12838 and phpmyadmin#12069

Signed-off-by: Michal Čihař <michal@cihar.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants