metadata-service[orchestrator]: set SBOM url in registry #44381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
e28e7f6
to
56f5445
Compare
8eb8c56
to
d3da46d
Compare
56f5445
to
56d8030
Compare
bc94f7a
to
a8a8d8a
Compare
natikgadzhi
reviewed
Aug 19, 2024
| return metadata_dict | ||
| response = requests.head(sbom_url) | ||
| if response.ok: | ||
| metadata_dict = set_(metadata_dict, "data.generated.sbomUrl", sbom_url) |
There was a problem hiding this comment.
For my education: do we put a lot of things in generated metadata key?
There was a problem hiding this comment.
This is what currently ends up as generated metadata. It's mainly to feed the doc with marketplace metrics.
natikgadzhi
approved these changes
Aug 19, 2024
56d8030
to
de4e12f
Compare
a8a8d8a
to
c38f34e
Compare
Base automatically changed from
augustin/08-19-metadata-service_lib_add_sbom_url_to_generated_registry_fields
to
master
August 20, 2024 07:38
c38f34e
to
2f872fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes https://github.com/airbytehq/airbyte-internal-issues/issues/8991
We want to populate the
generatedfield of connector a registry entry with an URL to its SBOM.How
HEADrequest.generatedfields with thesbomUrl.