[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add SBOM url to metadata state in connector documentation #44386

Conversation

alafanechere
Copy link
Contributor
@alafanechere alafanechere commented Aug 19, 2024

What

Closes #44385

We want to expose the SBOM url in the connector documentation

How

Pass the sbomUrl from the registry entry down to a metadata stat component

Example

From the Vercel preview

Screenshot 2024-08-20 at 10 37 36 Screenshot 2024-08-20 at 10 58 36

Copy link
vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 9:07am

@alafanechere alafanechere force-pushed the augustin/08-19-metadata-service_orchestrator_set_SBOM_url_in_registry branch from d3da46d to bc94f7a Compare August 19, 2024 09:55
@alafanechere alafanechere force-pushed the augustin/08-19-docs_add_SBOM_url_to_metadata_state_in_connector_documentation branch from ae4a5ff to f7469af Compare August 19, 2024 09:55
@alafanechere alafanechere force-pushed the augustin/08-19-metadata-service_orchestrator_set_SBOM_url_in_registry branch from bc94f7a to a8a8d8a Compare August 19, 2024 10:21
@alafanechere alafanechere force-pushed the augustin/08-19-docs_add_SBOM_url_to_metadata_state_in_connector_documentation branch from f7469af to db40e50 Compare August 19, 2024 10:21
@alafanechere alafanechere force-pushed the augustin/08-19-docs_add_SBOM_url_to_metadata_state_in_connector_documentation branch from db40e50 to 58c411d Compare August 19, 2024 10:45
@alafanechere alafanechere requested review from bnchrch and a team August 19, 2024 11:03
@alafanechere alafanechere marked this pull request as ready for review August 19, 2024 11:03
Copy link
Contributor
@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, but can you get away without the pnpm-lock change?

@@ -1,5886 +1,406 @@
lockfileVersion: '9.0'
lockfileVersion: '6.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version change looks very sus

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks for catching that!

@alafanechere alafanechere force-pushed the augustin/08-19-metadata-service_orchestrator_set_SBOM_url_in_registry branch from a8a8d8a to c38f34e Compare August 20, 2024 06:54
@alafanechere alafanechere force-pushed the augustin/08-19-docs_add_SBOM_url_to_metadata_state_in_connector_documentation branch from 58c411d to da8b75b Compare August 20, 2024 06:55
@alafanechere alafanechere force-pushed the augustin/08-19-metadata-service_orchestrator_set_SBOM_url_in_registry branch from c38f34e to 2f872fa Compare August 20, 2024 07:52
@alafanechere alafanechere force-pushed the augustin/08-19-docs_add_SBOM_url_to_metadata_state_in_connector_documentation branch from da8b75b to f0fcbec Compare August 20, 2024 07:53
Base automatically changed from augustin/08-19-metadata-service_orchestrator_set_SBOM_url_in_registry to master August 20, 2024 07:58
@alafanechere alafanechere force-pushed the augustin/08-19-docs_add_SBOM_url_to_metadata_state_in_connector_documentation branch from f0fcbec to b2b7143 Compare August 20, 2024 08:30
@alafanechere alafanechere force-pushed the augustin/08-19-docs_add_SBOM_url_to_metadata_state_in_connector_documentation branch from b2b7143 to ca34357 Compare August 20, 2024 08:45
@alafanechere alafanechere force-pushed the augustin/08-19-docs_add_SBOM_url_to_metadata_state_in_connector_documentation branch from ca34357 to f6dcbce Compare August 20, 2024 09:03
@alafanechere
Copy link
Contributor Author

@natikgadzhi the doc preview looks great now. Ready to 👍 ?

@alafanechere alafanechere enabled auto-merge (squash) August 20, 2024 16:49
Copy link
Contributor
@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alafanechere alafanechere merged commit a240846 into master Aug 20, 2024
30 checks passed
@alafanechere alafanechere deleted the augustin/08-19-docs_add_SBOM_url_to_metadata_state_in_connector_documentation branch August 20, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update connector documentation with an SBOM url
3 participants