-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add SBOM url to metadata state in connector documentation #44386
docs: add SBOM url to metadata state in connector documentation #44386
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on Graphite |
d3da46d
to
bc94f7a
Compare
ae4a5ff
to
f7469af
Compare
bc94f7a
to
a8a8d8a
Compare
f7469af
to
db40e50
Compare
db40e50
to
58c411d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks fine, but can you get away without the pnpm-lock
change?
docusaurus/pnpm-lock.yaml
Outdated
@@ -1,5886 +1,406 @@ | |||
lockfileVersion: '9.0' | |||
lockfileVersion: '6.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version change looks very sus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks for catching that!
a8a8d8a
to
c38f34e
Compare
58c411d
to
da8b75b
Compare
c38f34e
to
2f872fa
Compare
da8b75b
to
f0fcbec
Compare
f0fcbec
to
b2b7143
Compare
b2b7143
to
ca34357
Compare
ca34357
to
f6dcbce
Compare
@natikgadzhi the doc preview looks great now. Ready to 👍 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What
Closes #44385
We want to expose the SBOM url in the connector documentation
How
Pass the
sbomUrl
from the registry entry down to a metadata stat componentExample
From the Vercel preview