[go: nahoru, domu]

Skip to content

Commit

Permalink
Update compress-commons for Node 15 support (#28)
Browse files Browse the repository at this point in the history
* Update `compress-commons` for Node 15 support

Right now we're producing ZIP files with incorrect CRC32s on Node 15+.
This has a few of effects:

- macOS Finder gets confused and doesn't detect the ZIP file as password
  protected. Instead, it unzips everything as a 0 byte file

- Running `unzip` from the command line succeeds but warns about
  incorrect CRC32

- Our unit tests (correctly) fail

This is ultimately due to archiverjs/node-crc32-stream#31

To pull in the fix for that we need `crc32-stream@4.0.2`. That requires
updating both `compress-commons` and `zip-stream` to their latest
versions.

The version bumps look scary here but they're mostly due to dropping
support for old Node versions. They now require Node 10+; this should be
fine considering our Travis config only tests 12+.

* Update `package-lock.json`
  • Loading branch information
etaoins committed Jun 8, 2021
1 parent d0b7a75 commit dda6c14
Show file tree
Hide file tree
Showing 2 changed files with 102 additions and 78 deletions.
176 changes: 100 additions & 76 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
"aes-js": "^3.1.2",
"archiver": "^3.1.1",
"archiver-utils": "^2.1.0",
"compress-commons": "^1.2.2",
"zip-stream": "^2.1.3"
"compress-commons": "^4.1.1",
"zip-stream": "^4.1.0"
},
"devDependencies": {
"coveralls": "^3.1.0",
Expand Down

0 comments on commit dda6c14

Please sign in to comment.