Update compress-commons for Node 15 support
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we're producing ZIP files with incorrect CRC32s on Node 15+. This has a few of effects: - macOS Finder gets confused and doesn't detect the ZIP file as password protected. Instead, it unzips everything as a 0 byte file - Running `unzip` from the command line succeeds but warns about incorrect CRC32 - Our unit tests (correctly) fail This is ultimately due to archiverjs/node-crc32-stream#31 To pull in the fix for that we need `crc32-stream@4.0.2`. That requires updating both `compress-commons` and `zip-stream` to their latest versions. The version bumps look scary here but they're mostly due to dropping support for old Node versions. They now require Node 10+; this should be fine considering our Travis config only tests 12+.
|
Hi @etaoins, thank you for PR. Travis build for node 12&14 does not pass: https://travis-ci.org/github/artem-karpenko/archiver-zip-encrypted/jobs/773897807. It seems to complain about inconsistency between package.json and package-lock.json, even though I do see that package-lock.json is part of this PR. Could it be that it's not of in sync with package.json though? |
|
Sorry about that! I think I forgot to update it after realising I needed |
|
Thanks! Version 1.0.10 has been published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we're producing ZIP files with incorrect CRC32s on Node 15+. This has a few effects:
macOS Finder gets confused and doesn't detect the ZIP file as password protected. Instead, it unzips everything as a 0 byte file
Running
unzipfrom the command line succeeds but warns about incorrect CRC32Our unit tests (correctly) fail
This is ultimately due to archiverjs/node-crc32-stream#31
To pull in the fix for that we need
crc32-stream@4.0.2. That requires updating bothcompress-commonsandzip-streamto their latest versions.The version bumps look scary here but they're mostly due to dropping support for old Node versions. They now require Node 10+; this should be fine considering our Travis config only tests 12+.