This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
fix workload status for multiple revision case #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b799f02
to
0451f12
Compare
Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
0451f12
to
f8b539c
Compare
pkg/controller/v1alpha2/applicationconfiguration/applicationconfiguration.go
Show resolved
Hide resolved
| }) | ||
|
|
||
| func readYaml(path string, object runtime.Object) error { |
There was a problem hiding this comment.
this seems to be a useful helper function, maybe move it to some more common place?
There was a problem hiding this comment.
it's a small function, and I didn't see we need to use it in our business code, so I leave it here
There was a problem hiding this comment.
at least make this available for other tests?
There was a problem hiding this comment.
Let's put it next time if we need it
f338293
to
2f3a367
Compare
Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
2f3a367
to
2beaae7
Compare
ryanzhang-oss
approved these changes
Sep 2, 2020
zzxwill
pushed a commit
to zzxwill/oam-kubernetes-runtime
that referenced
this pull request
Sep 10, 2020
* fix workload status for multiple revision case Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com> * add CurrentWorkingRevision flag in workload status Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com> Signed-off-by: zzxwill <zzxwill@gmail.com>
gaius-qi
pushed a commit
to gaius-qi/oam-kubernetes-runtime
that referenced
this pull request
Nov 10, 2020
* fix workload status for multiple revision case Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com> * add CurrentWorkingRevision flag in workload status Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com> Signed-off-by: gaius.qi <gaius@qiwenbo.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For revisionEnabled case, oam runtime will generate multiple workload, while only one workload per component will list in status of AppConfig.
This PR will fix it and list all workloads in status of appconfig.
Signed-off-by: 天元 jianbo.sjb@alibaba-inc.com