-
Notifications
You must be signed in to change notification settings - Fork 80
fix workload status for multiple revision case #190
Conversation
b799f02
to
0451f12
Compare
Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
0451f12
to
f8b539c
Compare
pkg/controller/v1alpha2/applicationconfiguration/applicationconfiguration.go
Show resolved
Hide resolved
}) | ||
|
||
func readYaml(path string, object runtime.Object) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to be a useful helper function, maybe move it to some more common place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a small function, and I didn't see we need to use it in our business code, so I leave it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at least make this available for other tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put it next time if we need it
f338293
to
2f3a367
Compare
Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
2f3a367
to
2beaae7
Compare
* fix workload status for multiple revision case Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com> * add CurrentWorkingRevision flag in workload status Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com> Signed-off-by: zzxwill <zzxwill@gmail.com>
* fix workload status for multiple revision case Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com> * add CurrentWorkingRevision flag in workload status Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com> Signed-off-by: gaius.qi <gaius@qiwenbo.com>
For revisionEnabled case, oam runtime will generate multiple workload, while only one workload per component will list in status of AppConfig.
This PR will fix it and list all workloads in status of appconfig.
Signed-off-by: 天元 jianbo.sjb@alibaba-inc.com