[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Suppress Errors When Creating Data Directory #1344

Merged
merged 3 commits into from
Dec 11, 2020
Merged

Don't Suppress Errors When Creating Data Directory #1344

merged 3 commits into from
Dec 11, 2020

Conversation

4e6
Copy link
Contributor
@4e6 4e6 commented Dec 10, 2020 •
edited
Loading

Pull Request Description

close #1342

Don't suppress errors when creating the data directory.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@4e6 4e6 requested a review from kustosz as a code owner December 10, 2020 17:41
@4e6 4e6 self-assigned this Dec 10, 2020
@4e6 4e6 requested a review from lolczak as a code owner December 10, 2020 17:41
@4e6 4e6 changed the title Log Errors When Creating Data Directory Don't Suppress Errors When Creating Data Directory Dec 11, 2020
@4e6 4e6 merged commit 2e026b4 into main Dec 11, 2020
@4e6 4e6 deleted the wip/db/language-server-log-dir-creation branch December 11, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolczak lolczak lolczak approved these changes

@kustosz kustosz Awaiting requested review from kustosz

Assignees

@4e6 4e6

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Language Server should Log Errors When Creating Config Directory
2 participants
@4e6 @lolczak