[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[match] provide additional warning context on nuke #16351

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

heisenbugged
Copy link
@heisenbugged heisenbugged commented Apr 21, 2020

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

I stupidly ran nuke at my organization, expecting it nuke local (not server) configuration. Hopefully updating the verbiage a bit will prevent someone else from making the same silly mistake I did.

Description

Very simple change. Just verbiage update.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@heisenbugged
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@janpio janpio requested a review from joshdholtz April 23, 2020 20:19
@joshdholtz joshdholtz changed the title Provide additional warning context on nuke [match] provide additional warning context on nuke May 12, 2020
Copy link
Member
@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion for some rewording! Let me know your thoughts 😊

match/lib/match/nuke.rb Outdated Show resolved Hide resolved
getaaron and others added 2 commits August 4, 2022 21:12
@getaaron
Copy link
Collaborator
getaaron commented Aug 5, 2022

@babylone-star @joshdholtz I cleaned this up a bit to match (no pun intended) with #19617 let me know what you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants